Giter Club home page Giter Club logo

Comments (3)

wdouglass avatar wdouglass commented on September 1, 2024

@maxhawkins i really like your solution. Should the user call CompoundPacket.Validate themselves, or should it get called by pions/webrtc? should there be an option that gets set somewhere?

from rtcp.

maxhawkins avatar maxhawkins commented on September 1, 2024

rtcp-rsize is negotiated out of band so there's no way to know if you're in RFC 3350 mode or RFC 5506 mode.

I suppose you could have something like

type Unmarshaler struct {
  ReducedSize bool
}

and then Unmarshaler{false}.Unmarshal(...). Not sure if that's worth it.

What were you thinking?

from rtcp.

wdouglass avatar wdouglass commented on September 1, 2024

Maybe we should leave that out of pions/rtcp, and let downstream deal with deciding whether to validate. I guess pions/webrtc knows whether it negotiated rtcp-rsize or not, and therefore it's responsible for the validation, but i'm really not sure about that

from rtcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.