Comments (3)
@maxhawkins i really like your solution. Should the user call CompoundPacket.Validate
themselves, or should it get called by pions/webrtc? should there be an option that gets set somewhere?
from rtcp.
rtcp-rsize is negotiated out of band so there's no way to know if you're in RFC 3350 mode or RFC 5506 mode.
I suppose you could have something like
type Unmarshaler struct {
ReducedSize bool
}
and then Unmarshaler{false}.Unmarshal(...)
. Not sure if that's worth it.
What were you thinking?
from rtcp.
Maybe we should leave that out of pions/rtcp, and let downstream deal with deciding whether to validate. I guess pions/webrtc knows whether it negotiated rtcp-rsize or not, and therefore it's responsible for the validation, but i'm really not sure about that
from rtcp.
Related Issues (20)
- Dependency Dashboard
- ntptime should use uint32 HOT 1
- v2 of this package HOT 6
- Implement missing validity checks from RFC HOT 1
- Port old fuzzing code to Go's new fuzzing tools
- Some RTCP packets don't have String() methods
- Add Marshal to CompoundPacket
- Impossible to parse a header with padding HOT 1
- Add support for Reduced-Size RTCP (RFC 5506)
- Make it easier to construct CNAME packets
- Make CompoundPacket an rtcp.Packet
- Remove Decoder
- Add transport-cc
- Handling of padding in TransportCC HOT 1
- Fix PictureLossIndication Unmarshal error
- Implement RTCP XR
- Action Required: Fix Renovate Configuration
- Rapid Resynchronisation Request HOT 2
- ReceiverReport.Unmarshal readability HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rtcp.