Comments (4)
I definitely forgot about handling non-discrete values in the design. At first, I figured that it was nice to have this design because then you can do a sanity check in the wrapper level, and let the adapter implementors to simply use the prop.
from mediadevices.
As you have suggested in #69, it would be nice to have an interface from the wrapper to get the default value.
But, I think instead of putting the interface in Wrapper, we can put it under prop
since the default values shouldn't be dependent on anything.
So, we probably have something like,
func (p Media) Default() prop.Media
Or probably even have it in package level
package prop
var Default = prop.Media{
...
}
What do you think?
from mediadevices.
I think the default values (especially continuous parameters) depends on the actual device.
For example camera would have default framerate of 30fps in most case. But, screen capture maybe 10fps since it's too heavy at 30fps.
from mediadevices.
I see. If that's the case, I'm not seeing that we can do better than we already have rn, set the default value in each adapter implementation.
from mediadevices.
Related Issues (20)
- Colour difference in generated video stream HOT 1
- How does screen capture work on Windows vs Linux? HOT 2
- ForceKeyFrame HOT 3
- Failed to start streaming: invalid argument HOT 5
- go build linux error HOT 3
- Add pion/.goassets
- GCC problem on Windows 10 HOT 1
- Display mouse cursor HOT 1
- Video not showing in video element in latest versions of chrome. HOT 5
- why does opening dev console in http example crash the server?
- rtp example problems
- Distorted audio capture on linux. HOT 5
- failed to find the best driver that fits the constraints to open usb camera HOT 1
- Multiple display for webcam device HOT 2
- use mediadevices.GetUserMedia() failed. err: failed to open device: failed to connect filters HOT 2
- jetson agx xavier ubuntu20.04 fail run HOT 2
- webrtc demo mic Sound tearing sensation
- Error in bridge.cpp when using openh264
- go1.22.2 - example/webrtc Audio works, but video doesnt HOT 5
- Video not show on mobile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mediadevices.