Comments (17)
This is the only thing that is preventing us from seriously evaluate this tool!
Looking forward!
from pino.
@davidmarkclements, just now getting back to GitHub.
It looks beautiful! I love it.
from pino.
We need to support this in the web framework modules too!
from pino.
@XVincentX, this is already possible, but probably not easy nor documented :D.
@davidmarkclements we should test this in the context of hapi-pino and pino-http. Probably we need options added there too.
from pino.
@XVincentX got a first pass going on here https://github.com/davidmarkclements/pino-noir won't be long coming :)
from pino.
@mcollina agreed - maybe pino-noir should be included in pino-http and hapi-pino by default and just pass a filter object through - is that your position?
from pino.
Ok, https://github.com/davidmarkclements/pino-noir is fully working, version 0.0.1 publish to npm too
Works for top level keys and nested keys, does not yet support wildcards, we need to run benchmarks & profile but it should be quite fast since we avoid copying objects to redact nested values by piggy backing on the subsequent JSON.stringify loop
@emilyrose would love to get your feedback for pino-noir API
from pino.
@mcollina - just to say, since all inputs are strings (or array of strings), we can obv go faster by removing closure scope and compiling a string and passing to new Function, and again apply this same thinking to _.get and _.set - however, I'd like to benchmark the diff if it's not significant enough I'd rather not use new Function
from pino.
That sounds great. Let me marinate the new things and I'll give it a try.
from pino.
@emilyrose - I've started on wildcard functionality on the plane, it's not quite there - my time is limited next couple of days so - I'll push anyway in case you want to bring it to land (@XVincentX feel free to PR too!) - immediate steps after that are setting up an integration benchmark, we can copy the object logging benchmarks from pino, and put pino-noir in the middle to benchmark general usage, and wildcard usage
from pino.
I'd love to but I am not sure I'm the right person (time/competencies ratio) to do that!
from pino.
@davidmarkclements what's the status of this?
from pino.
it needs a few hours input to get wildcard done - just need the time
from pino.
done :)
from pino.
oh wait, need to add to pino readme - doing
from pino.
Oh yah this is done
from pino.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from pino.
Related Issues (20)
- `stdSerializers` cannot be avoided for Request and Response HOT 4
- How to add context data using the same pino instance HOT 6
- `level` filter not work for transports HOT 3
- Redacting still modifies original data HOT 1
- Forbid using default log levels when `useOnlyCustomLevels: true` HOT 2
- pino transport - is it worth using a transport in another process for writing to stdout? HOT 4
- Unable to gracefully shut down transport HOT 4
- Restore and automate airtap testing HOT 3
- Package size HOT 8
- Improve generics for Logger, LoggerOptions, LogFn and WriteFn
- Error: "fn is not a function" while setting up a pino transports since v9.2.1 HOT 8
- sonic boom is not ready yet HOT 2
- Error: unable to determine transport target for "@baselime/pino-transport" HOT 2
- Typescript: turn Level typings into an enum HOT 2
- [bug] logger.`setBindings` undefined when using esm exported pino HOT 2
- Accept log level env var as UPPER or LOWER case HOT 4
- Mutation of log inputs - (un)expected? HOT 8
- Recipe for email notifications? HOT 1
- getting the following message: pinoWebpackAbsolutePath is not defined HOT 2
- Endless issues of Error: Cannot find module '....\.next\server\vendor-chunks\lib\worker.js' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pino.