Window/unix difference with os.rename about odmpy HOT 5 CLOSED

Were you able to execute run_tests.sh on Windows?

The rename seems to have failed because ''tests/data/downloads/Ceremonies For Christmas - Robert Herrick\Ceremonies For Christmas - Robert Herrick.mp3'' already exists. I'm guessing this was remnant output from a previous test that was not properly cleared.

from odmpy.

Switching over to os.replace() seems a fairly minor change so I've gone ahead and done that on the master branch.

from odmpy.

Yes, I ran the tests using git bash on windows, the tests with a basic charset usage pass fine, but the full UTF-8 tests fail. On windows the default charset is cp1252 it is dies on the extended characters, and I can't figure out where the windows 'default' encoding is applied when running the tests.

And yes, exactly that -above-. The remnant of the previous merge test causes the second one to fail on windows.

# download + merge into mp3
  rm -rf "$TEST_DOWNLOAD_DIR" && mkdir -p "$TEST_DOWNLOAD_DIR"
  python -m odmpy dl "$TEST_DATA_DIR/$TEST_ODM" -d "$TEST_DOWNLOAD_DIR" -m --hideprogress > /dev/null
  python -m unittest -v tests.OdmpyTests.test_download_2
  # download + merge into m4b
  python -m odmpy dl "$TEST_DATA_DIR/$TEST_ODM" -d "$TEST_DOWNLOAD_DIR" -m --mergeformat m4b --hideprogress > /dev/null
  python -m unittest -v tests.OdmpyTests.test_download_3

from odmpy.

not sure what your supported python versions are, but os.replace is 3.3+
you could delete if exists before os.rename if you wanted to keep it.

from odmpy.

not sure what your supported python versions are, but os.replace is 3.3+ you could delete if exists before os.rename if you wanted to keep it.

Python support is >=3.7 so I think it should be fine. Thanks for the report.

from odmpy.