Giter Club home page Giter Club logo

Comments (7)

bigpick avatar bigpick commented on May 22, 2024 2

The dev branch airline looks a lot better wrt the other bullets I pointed out (also like the warning color being toned down much more too and the fg changing on modes as well is nice), but the issue with the inactive text is still there:

Screen Shot 2021-06-04 at 11 03 58 AM

from spaceduck.

jinh0 avatar jinh0 commented on May 22, 2024 2

Hey @bigpick , thanks for taking the time to use the dev branch! Glad you're liking my airline. Thanks for letting me know about the inactive text being too dark. I'll fix it this weekend! 😊

from spaceduck.

pineapplegiant avatar pineapplegiant commented on May 22, 2024 1

You bring up a lot of good points that I do wanna address, but I wanna respond quickly.

Mmm @jinh0 has been working on the airline theme. Can you check out the dev branch and let me know what you think? We’re working on expanding the color palette and we fixed some issues with readability (like on comments) on that branch that I’m hoping to push to main this weekend.

from spaceduck.

pineapplegiant avatar pineapplegiant commented on May 22, 2024 1

I’ve thought about it a little bit (I didn’t expect people to like the theme and contribute at all 😅).

I really like nord and how they handle things, such a well designed theme (although the colors are too muted imo). So I’ve thought about creating a gatsby site like how they have done and in the mean time moving everything non plugin related to the wiki.

I’m open to any suggestions, of course.

from spaceduck.

jinh0 avatar jinh0 commented on May 22, 2024 1

Hey @bigpick I used your fix for the inactive colors and also replaced the #000000 with #0f111b like you mentioned. It's been pushed to the dev branch with this commit. Thanks for the issue.

Regarding the organization of the ports, I think that is a bigger discussion that should be its own issue / discussion post. If I may put in my two cents however, I think a big Dracula-like website is a far stretch as of now since Spaceduck is still figuring out the colors to use.

I'll close this issue if there's no further issue with Airline.

from spaceduck.

bigpick avatar bigpick commented on May 22, 2024

Awesome, thanks, I'll take a look at that.

For the organizational stuff, have you thought much about if (or how if so) to go towards that route, or no? I guess, just would be curious if in the meantime developing ports for other things, what the best way to then "get them added to the theme" would be best (currently, looks like just links to others personal repo's in the main README)

from spaceduck.

bigpick avatar bigpick commented on May 22, 2024

I agree, nord's site is pretty nice. I think that though also includes a lot of additional work to maintain a good looking site (kinda true for any approach though so), and from what I can tell, two places of information for a given port?

e.g nord-vim has its own repo under the org, but on the site (https://www.nordtheme.com/ports/vim) it has its own web page that isn't tied at all wrt source/infromation/etc to the nord-vim repo itself, so when one is updated, the other also then needs to get updated as well (nord-docs)

I don't know that it is a necessarily large burden, and may actually be viewed as a benefit, as keeping the two separate helps avoid needing to include submodule type things, which tends to be love/hate.

Coming from mostly using/looking at Dracula+contributing there sometimes, I guess the other sort of option for the organizational stuff would be like how Dracula does it, which similar to nord is a repo with repos for each port and a main repo for the "theme itself"/website, but then how things are managed are just slightly different. That said, I think Dracula's site is probably more simplistic (not a dig) than Nord's, but I think I like how they manage the individual ports better (I seem to get the feeling that most of the nord stuff has to go through the articicestudio entity, whereas the Dracula things, you don't see Zeno required to be personally approving/merging everything). To be fair, I've not really looked at Nord's much, so all of those opinions may be totally wrong though, so maybe I am just ignorant on most things Nord still

from spaceduck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.