`bool` encoding about firehose-antelope HOT 13 CLOSED

This is weird. The decoder correctly decodes the value to "true". So maybe this is happening on some (un-)marshalling step. Do you know of an action that contains a boolean value in it's data? Would like to check if this is a common thing with all nested boolean values or if it's only impacting the decoded table data.

from firehose-antelope.

Do you know of an action that contains a boolean value in it's data?

You mean boolean action param?
Here's one

Looks like it's also encoded as 1.

from firehose-antelope.

Hmm ok I'll need to take a deeper look into this. Do you know if it's consistent behaviour to encode nested json data into 0/1 or does this impact only certain actions?

from firehose-antelope.

Looks consistent. Here's eosio::deletegatebw call: https://eos.eosq.eosnation.io/tx/bd1bd84da20a7028c14d3404a544fe86a91d7e423ab6db64d7a2cea18f927a3a

from firehose-antelope.

Jul 07 10:37:50 eos-sfdm41 nodeos[1519058]: 2023-07-07T10:37:50.772Z DEBG (codec) decoding action {"action": "eosio:delegatebw", "global_sequence": 358638274958}
Jul 07 10:37:50 eos-sfdm41 nodeos[1519058]: 2023-07-07T10:37:50.772Z DEBG (codec) found ABI and action definition, performing decoding {"action": "eosio:delegatebw", "global_sequence": 358638274958}
Jul 07 10:37:50 eos-sfdm41 nodeos[1519058]: 2023-07-07T10:37:50.772Z DEBG (codec) successfully decoded action data {"action": "eosio:delegatebw", "json_data": "{\"from\":\"kingparallax\",\"receiver\":\"kingparallax\",\"stake_cpu_quantity\":\"27.9807 EOS\",\"stake_net_quantity\":\"0.0000 EOS\",\"transfer\":0}"}

from firehose-antelope.

Ok so I copied out the decoding part, ran it locally with a delegatebw action and it is properly decoding the boolean value to true/false instead of 0/1. This is weird.

Looking at the battlefield-eosio repository it seems like the boolean decoding always has been to 0/1 (it's how nested json strings with booleans are encoded in the golden.json files which were used to test against with linediff).

from firehose-antelope.

OK, so we are keeping it this way?

from firehose-antelope.

I assume yes, unless you get maoueh to say otherwise.

from firehose-antelope.

Related commit where they changed the decoding to byte

Then they added fitNodeos flag.

So they did it to align with nodeos.

Is there any downside if we just decode it as true/false?

from firehose-antelope.

I love we can find the code change for that.

from firehose-antelope.

Setting fitNodeos to false has other implications on parsings, like int128 getting parsed into a string instead of a number. Not sure what the impacts are when changing that.

Seems like Matthieu doesn't know either.

from firehose-antelope.

@YaroShkvorets is this still relevant or should we close the issue?

from firehose-antelope.

I guess we can close it.

from firehose-antelope.