Giter Club home page Giter Club logo

Comments (3)

PiN73 avatar PiN73 commented on June 15, 2024 2

Anyway we should add caching. With current straightforward implementation,

Image(
  image: ThumbHash.fromBase64('3OcRJYB4d3h/iIeHeEh3eIhw+j3A').toImage(),
)

seems to make decoding (plus encoding to bmp) on each build.

Instead of this, we should make API like

Image(
  image: ThumbHashImage.fromBase64('3OcRJYB4d3h/iIeHeEh3eIhw+j3A'),
)

where ThumbHashImage is ImageProvider which will decode to bmp (in isolate or not) once and cache the result.

from thumbhash.

vaetas avatar vaetas commented on June 15, 2024 1

Yes, using ImageProvider would be way better. Doing it on every build a big performance issue.

As far as the Isolate goes we can leave this open and do the benchmarks when there is time.

from thumbhash.

PiN73 avatar PiN73 commented on June 15, 2024

Thank you, it's interesting to think about.

Just wrapping functions with Future won't help because actual decoding will be still synchronous.

However, it's worth benchmarking decoding algorithm. Maybe it takes short time because thumbhash image is decoded maximum to 32x32 pixels. If it turns out that it takes long time, then I will consider decoding in Isolate for flutter_thumbhash.

from thumbhash.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.