Giter Club home page Giter Club logo

Comments (6)

WhyNotHugo avatar WhyNotHugo commented on July 26, 2024

Okay, so this makes sense. I was actually thinking of additional changes that contribute to this:

  1. Make compact_format configurable (via the configuration file -- no cli flag).
  2. Introduce a new time_format setting (as you suggested).
  3. Change compact_format to include separate due_date and due_time component: {id:3d} [{completed}] {urgent} {due_date} {due_time} {summary} {list}{percent}. I'm not sure if I want to change the default or not. What I am sure of, is that it'll allow you to retain you current output. πŸ˜‰
  4. The "today"/"tomorrow" thingy will only replace due_date, having no effect on the time (we'll probably add Formatter.parse_time.
  5. Double check how all this affects --porcelain (tests will quickly squeal if we break it though).

from todoman.

untitaker avatar untitaker commented on July 26, 2024

I'm labelling this hard because of the introduction of compact_format. I don't think --porcelain will be affected by this at all. It ignores all format options.

from todoman.

WhyNotHugo avatar WhyNotHugo commented on July 26, 2024

I just realized we need to implement this for #108 to work/make sense (for some reason I'd assumed we'd done this already).

from todoman.

untitaker avatar untitaker commented on July 26, 2024

I don't understand what you mean. What did you think was implemented already?

from todoman.

WhyNotHugo avatar WhyNotHugo commented on July 26, 2024

Well, without date/time separation (the suggestion here), the code for #108 won't work, because format_date actually receives a datetime object.

from todoman.

untitaker avatar untitaker commented on July 26, 2024

#117 fixes this. I chose a route that doesn't implement a config option for compact_format. The dt_separator is necessary in either case because we need to use it for parsing input as well.

from todoman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.