Add static file directive to nginx config about pilothouse HOT 10 CLOSED

I've added above the / and php directives in my config:

from pilothouse.

Probably need to be smarter about the css/js files as then they get cached too long

from pilothouse.

@AaronHolbrook I'm confused as to why this is needed. Aren't static files already being served directly without involving PHP?

from pilothouse.

Okay, I did some investigating and I think it's if the file does not exist that it gets passed to PHP that you were referring to, so we definitely do need this. I also see a similar directive in the wordpress.org recommended Nginx configuration.

However, I wonder, since this is a development environment, would we want any of these files to be cached? Obviously we would want to cache these in production environments, but on dev I'm thinking it'd be better not to cache any of this.

from pilothouse.

Yea that's where I was torn, on one hand we don't want to be passing unrealistic requests like favicon.ico continually to the php backend, since during debugging that causes additional fake requests to come in, but on the other hand caching static assets could be very problematic to seeing changes.

from pilothouse.

Maybe we should add in the favicon.ico block like the codex has as well

from pilothouse.

https://codex.wordpress.org/Nginx#Global_restrictions_file

from pilothouse.

Good idea; done.

from pilothouse.

Hmmm; looks like the static file directive is conflicting with image proxying from production. Reopening to investigate that.

from pilothouse.

Proxying was working fine; but all static assets were being proxied. Now only proxying image files, and only image files in an uploads directory.

from pilothouse.