Comments (9)
It is necessary because hbs uses layouts by default. If you don't want the layout feature, then you disable it with layout: false
from hbs.
Yep, I figured that out (see above). My question is: why does it use layouts by default?
from hbs.
Cause that is what I decided? I mean, it is arbitrary either way. I have found that most users generally want layouts by default, and those that don't know to turn it off.
from hbs.
Oh! I mean, if the file isn't there, perhaps we could assume that layout should be disabled?
from hbs.
Layout is an Express feature so it would be inappropriate to override at view engine level. I suggest filing an issue at Express project.
from hbs.
Actually, from what I understand, it is no longer an express feature as of 3.x It is left to the template engines to decide how or if they wish to do layout type things. For example, jade does it completely differently.
I am not against being silent about the lack of layout.hbs file and skipping when not available. However, if layout is specifically set to true, then I think the error should happen. Thoughts?
from hbs.
I'd vote for an throwing an error.
from hbs.
Ha. Looks like Express 3.0 changes are more extensive than I thought.
Re whether to throw error, I think a warning is more appropriate if layout
value exists and is true
.
More interesting situation is when layout.hbs
exists and layout
value doesn't exist. I think presence of layout.hbs
file is equivalent to layout
set to true. User can force hbs
to ignore layout.hbs
by setting layout
to false
. Question is whether to inform the user about this via info or warning.
from hbs.
+1 throwing an error for layout: true
from hbs.
Related Issues (20)
- Update handlebars dependency to 4.1.0 HOT 1
- [Security Alert] Upgrade handlebars to 4.1.0 or later HOT 1
- high severity vulnerability HOT 1
- Partial's passing value don't rendering after a space, in express hbs HOT 2
- Access hbs variable in external js file HOT 1
- npm audit security issue with handlebars 4.0.x HOT 8
- Error: Failed to lookup view "index" in views directory - Where is problem? HOT 4
- NPM Audit Security Issue with handlebars HOT 2
- Handlebars: Access has been denied to resolve the property "statements" because it is not an "own property" of its parent. HOT 3
- Handlebars 4.7.3 HOT 1
- Low security on minimist HOT 3
- Outdated dependency 'minimist' HOT 3
- Using registePartials twice disables app.locals HOT 3
- Can i use multiple videv engines with this framework? HOT 1
- Is it possible to pass an object(or JSON) from express to a specific partial(for use by another contained js app)? HOT 1
- Security Contact Needed HOT 2
- css file problem. HOT 1
- CSS not loaded when more than one '/' in the path HOT 1
- Error trying to use hbs on express
- How can I clear the cache? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hbs.