Giter Club home page Giter Club logo

Comments (7)

jed avatar jed commented on July 18, 2024

well, that's no good. @mtkopone, would you mind taking a look at your last commit?

from cookies.

mtkopone avatar mtkopone commented on July 18, 2024

Hi.
I'm having trouble reproducing this.

Assumed from res.json(...) that you're using express.

Wrote a test case in my fork for this, but it passes:
https://github.com/mtkopone/cookies/blob/fix-express-cookie-duplication/test/issue-20.js

One thing that might be relevant is the version of express you are using?

from cookies.

jed avatar jed commented on July 18, 2024

@think-free, let me know if the latest commit is now working for you, okay?

from cookies.

jedrichards avatar jedrichards commented on July 18, 2024

Hey ... I think I just had this issue too. Only the last cookie set was making it into the response headers. I'm using Restify not Express. Updating from 0.3.4 > 0.3.5 fixed it for me. Thx! ^^

from cookies.

think-free avatar think-free commented on July 18, 2024

Hi !
Same here, using restify not express.
I don't have a lot of time to test the last commit. I'll try to test it tomorrow ...
I can try to make a snippet reproducing this bug if the last commit doesn't solve the problem.
I'll tell you tomorrow ;)
Thanks

from cookies.

mtkopone avatar mtkopone commented on July 18, 2024

My bad. Didn't know people we using this with restify.

But should be fixed in 0.3.5.

Also, I wrote a test for restify, which is coming in a pull request.

from cookies.

jed avatar jed commented on July 18, 2024

the new restify tests from @mtkopone pass, so i'm going to assume this is fixed. let me know if you have any issues, @think-free.

from cookies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.