Comments (7)
well, that's no good. @mtkopone, would you mind taking a look at your last commit?
from cookies.
Hi.
I'm having trouble reproducing this.
Assumed from res.json(...)
that you're using express.
Wrote a test case in my fork for this, but it passes:
https://github.com/mtkopone/cookies/blob/fix-express-cookie-duplication/test/issue-20.js
One thing that might be relevant is the version of express you are using?
from cookies.
@think-free, let me know if the latest commit is now working for you, okay?
from cookies.
Hey ... I think I just had this issue too. Only the last cookie set was making it into the response headers. I'm using Restify not Express. Updating from 0.3.4 > 0.3.5 fixed it for me. Thx! ^^
from cookies.
Hi !
Same here, using restify not express.
I don't have a lot of time to test the last commit. I'll try to test it tomorrow ...
I can try to make a snippet reproducing this bug if the last commit doesn't solve the problem.
I'll tell you tomorrow ;)
Thanks
from cookies.
My bad. Didn't know people we using this with restify.
But should be fixed in 0.3.5.
Also, I wrote a test for restify, which is coming in a pull request.
from cookies.
the new restify tests from @mtkopone pass, so i'm going to assume this is fixed. let me know if you have any issues, @think-free.
from cookies.
Related Issues (20)
- Max length on cookie HOT 4
- Getting cookies of a request without having to pass response argument HOT 2
- Set Domain in options is not working HOT 3
- request.connection is deprecated
- set cookie with ";" is broken and the "signed" property returns undefined HOT 2
- Release sameSite = none PR HOT 3
- Storing cookie value + signature in a unified cookie instead of cookie_name.sig HOT 1
- Using this with Http2stream HOT 3
- How to install? HOT 1
- Migrate to travis-ci.com HOT 1
- Support of Sha256 HOT 1
- TypeError: Cannot read property 'encrypted' of undefined HOT 1
- make setHeader compatible with fastify reply (patch included) HOT 2
- Cookie maxAge HOT 1
- Using "signed: ture" will set two cookies? HOT 3
- missing cookie option "Priority" HOT 1
- How to allow multiple domains for CookieOptions.domain
- Get a cookie in 2023 HOT 1
- How to set SameSite attribute for .sig? HOT 1
- Cookies Having Independent Partitioned State (CHIPS, also know as Partitioned cookies) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cookies.