Giter Club home page Giter Club logo

Comments (7)

jed avatar jed commented on August 17, 2024

node scripts/install.js is all you need to make the default keys.

as for submodules, they've given me enough grief already, and keygrip is not a hard dependency; it's optional only if you want to sign cookies.

from cookies.

dvv avatar dvv commented on August 17, 2024

I'd say in our modern world unsigned cookies are evil ;)

I read the deprecation note and didn't get what is the killer improvement over cookie-node? Couldn't you elaborate on this? TIA

from cookies.

jed avatar jed commented on August 17, 2024

vladimir,

good point. i've added a Features section to the README. let me know if you have any other questions.

from cookies.

dvv avatar dvv commented on August 17, 2024

Plain text signed cookies, even though can't be tampered, seem a bit more disclosing than I'd expect. Just reading them at sniffer level already provides valuable info. Wrong?

So the hardened (in fact, vanilla) solution (using secure, httponly, and signed: true via keygrip (and of course HTTPS transport)) would be nice to have as a simple drop-in one-file-module.

Still, great repo, thanks!

from cookies.

jed avatar jed commented on August 17, 2024

i think that if you're putting valuable information in a cookie, you're doing it wrong, and no library should encourage that. so i don't think it's wise to try and over engineer something in this case.

do you think the secure and httpOnly defaults should be flipped?

from cookies.

dvv avatar dvv commented on August 17, 2024

I do put user id in cookie, that's requirement for a project I do. But they don't want it be "visible" in plain. I know that's quirky but so things are. NVM

No, defaults are ok to me. The only inconvenience so far is that keygrip require()s defaults even if they are not needed -- this leads to node scripts/install.js must be run ...

from cookies.

jed avatar jed commented on August 17, 2024

that makes sense.

i've changed defaultKeys.js into the plain JSON file defaultKeys.json

  • if keys are provided, it is not used.
  • if it exists keys aren't provided, it is loaded and used.
  • else an error is thrown.

for some reason the GitHub interface isn't reflecting this latest push yet, but it should be there soon.

from cookies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.