Django / Postgres example - need to move to it's own repo and update about piku HOT 22 CLOSED

This looks good, thanks. I think we should rename my implementation to sample-django-postgres-minimal and make yours the new sample-django-postgres.

Re: repetitive, I find it surprising how often "one off" becomes something I have to do more than once. 😁

from piku.

@jfmatth this looks great, thanks for providing an updated example. If it is ok with @rcarmo we can move your example to the piku organization, and you can make a PR to update the documentation to point to your example instead.

from piku.

@jfmatth one minor thing is the traditional capitalization is "Piku" not "PIKU" so it might make sense to update your README to reflect that. Not a huge deal or anything.

from piku.

Ok, built a first version of the idea, tell me what you think.

I'm happy for you guys to bring it over to the PIKU org or give me PR's to fix stuff then move it over. Either way, fun to work on this.

https://github.com/jfmatth/sample-django-postgres.git

from piku.

Hi again @jfmatth! Thanks for your offer to make an updated example, that sounds great. I guess the choice of more vs. less manual intervention is a matter of taste. My personal taste falls on the side of having more scripted in the code and less manual steps (because I'm always forgetting to do manual things) but I am sure there are many others who like it the other way. How about if we make a new repository with your take on best-in-class Django deployment to Piku? Thanks for the reminder to move migrate into the release script.

from piku.

Hi @chr15m I agree that scripting is good if it's repetitive , but in the case of Django and DB setup, I view that as a one-off exception).

from piku.

@chr15m - OK, so I took a closer look at your sample postgres one and made a new repo with something closer to what you're doing. I honestly didn't know a user could run postgres' createdb command and get themselves a DB, but makese total sense.

I moved a few things around, simplified the settings file, and updated to Django 4.x

Let me know what you think

https://github.com/jfmatth/piku-django4-postgres

from piku.

@jfmatth one other minor thing is you could add the 'migrate' step to your ./bin/stage_release.sh or else maybe put a note for the user about how to run it remotely when they are ready, as you've done with the create-db.

from piku.

@chr15m No worries, always glad to contribute.

You could either take the whole thing as an example repo for your org, or reference mine. Probably the former would be better, then you guys can own it and I can do PR's against it.

Dang it, I thought I put in the migrate command, but happy to add it after the above is decided. I don't like to migrate on every release, that seems too dangerous 😮

I

from piku.

I do have 'migrate' in the stage_release.sh command, but should mention in the README how to it manually.

from piku.

@chr15m Let me know after you pull it into your org, I have a few things I want to add like a DBNAME instead of using the NGINX_SERVER_NAME in the provision script. Some other 12-factor Django ideas Ill sprinkle in too.

from piku.

This issue is stale because it has been open for 90 days with no activity.

from piku.

This issue was closed because it has been inactive for 30 days since being marked as stale.

from piku.

@jfmatth sorry I haven't got around to this yet. I don't understand what I am supposed to do here to give you access. Can you let me know how you want to proceed? Can I just give you write access to the Django example repository?

from piku.

Hi @chr15m, Sure.

I was thinking you'd just bring the whole repo of mine into one of yours and either point to it in the docs or just leave it there like others.

I don't need access and would prefer just to use PR's to update it from time to time, if that's OK.

Hope this helps.

from piku.

This issue is stale because it has been open for 90 days with no activity.

from piku.

@jfmatth I checked the documentation and it seems you have to initiate this from your end. There's nothing I can actually do to bring it over I don't think.

https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository

Also:

To transfer a repository that you own to an organization, you must have permission to create a repository in the target organization.

And:

The original owner of the repository is added as a collaborator on the transferred repository. Other collaborators to the transferred repository remain intact.

I am fine with this myself as it would be less burden for you to maintain it, but need to check with @rcarmo.

from piku.

HI @chr15m, thanks for keeping this alive 😄

I'll read the docs and initiate if that's what it takes. I want to do some clean up first and then ill give it a go.

from piku.

Hi @chr15m

Sorry to take so long on this, been busy at a new job.

I tried transferring to the PIKU org, but don't have the rights. Not sure if you want to give me rights to do that or just fork it and take it over. I'm OK either way.

I see a lot of issues / traction around PIKU, great news.

from piku.

Ok, what about if you raise a PR against the current django + postgres repo and I'll merge it?

from piku.

Excellent idea. PR on it's way.

from piku.

Added new PR piku/sample-django-app#33 to Sample.

We should close this one @chr15m and reference the PR in the other repo

from piku.