Comments (8)
First of all it is an addon, PR no one will accept, Rubat certainly not, he will say some nonsense about security and that he is too lazy to check. The whole structure of the base mode was rewritten by me from scratch with a set of small changes outside of it.
from rebase.
"no one will accept" - did you try?
anyway, if you dont want to make PR - just make a fork, i want to audit your re-base - but i cant see whats you changed.
from rebase.
fork does not work that way, you will not see changes, or rather you will see that all files have been deleted and new ones created, if you want to see the code, look, fork will not help you at all. Now about Rubat, i hate him, I'm not going to do an updates for him.
from rebase.
But we aren't doing things for Rubat, we are doing them for community. Forking garrysmod repository is probably good idea. @PrikolMen
from rebase.
@dankmolot If I do a fork, it won't be re:base, it will be re:garrysmod or something like that...
from rebase.
ru shure? i have a https://github.com/parkervcp/yolks fork: https://github.com/Be1zebub/luvit-pterodactyl
there is no problem to change repo name
from rebase.
dont delete all files, just make a fork, delete all except garrysmod/base & replace files in it - then we will see changes in commit
from rebase.
We discussed this issue in discord https://discord.incredible-gmod.ru/ because its more convenient to have a long discussion.
if you are interested, you can read it here: https://discord.com/channels/559055559261814836/676068972185255987/1042884332865458197
Conclusion: fork/pr will not be because rebase is a gamemodes/base written from scratch - with a different structure that is backward incompatible.
I plan to make my facepunch/garrysmod fork and move all the changes from rebase there, so that it would be easy to merge.
What for? It will be possible to see the changes history, it will be possible to merge it, the project will never die.
I'll mention my fork here when I do that.
from rebase.
Related Issues (3)
- [bug] Баг с анимациями HOT 1
- Проблема Entity HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rebase.