Giter Club home page Giter Club logo

Comments (7)

Sushmey avatar Sushmey commented on May 26, 2024

Hi, I would like to try helping you. What do you mean when you say "make logo render clearer in chrome"?
Screenshot 2022-07-31 at 12 39 41 PM

from vodle.

mensch72 avatar mensch72 commented on May 26, 2024

Hi Sushmey, thank you for your offer and sorry for being unclear. This issue is about the menu in the app, where the logo looks like this in Chrome:
image
It seems to be antialiased in a different, less crisp way than in, say, Firefox, where it looks like this:
image
I guess the issue is a image size/resolution one. The place in code where the logo is referenced is in src/app/app.component.html, and the image is in assets/topleft_icon.png. Maybe something with the tag or the image file itself needs to be done, like rescaling or something.

from vodle.

mensch72 avatar mensch72 commented on May 26, 2024

Dear @Sushmey , did you make any progress with this?

from vodle.

Sushmey avatar Sushmey commented on May 26, 2024

Hi @mensch72 so sorry but I'm not actively working on this PR right now but I think adding this SCSS line in the app.component.scss file should help with the rendering difference in chrome and Firefox

.image-rendering:       
     webkit-optimize-contrast

from vodle.

mensch72 avatar mensch72 commented on May 26, 2024

Hm, I added

html {
    image-rendering: webkit-optimize-contrast;
}

but it doesn't seem to make a difference.

from vodle.

Wojtekb30 avatar Wojtekb30 commented on May 26, 2024

Hello.
First, Chrome and Firefox have different rendering engines. But I don't think that's really the issue here.
What I noticed is that the base image is too small. The browser has to upscale it, and as we know, making a small image bigger makes it look worse.
First, I would try putting a bigger full-res logo file, bigger than what finally renders (downscaling always looks better than upscaling, and it won't visibly affect performance).
Secondary, I would recommend trying using other image file types, like jpg, gif etc.
I would most recommend converting the logo to .svg and using the svg version, since vector graphics don't lose quality when changing size. I've seen websites which similarly render their logo in top left, and they use svg (vector) logo.
If you'd like, I can try to test and implement what's needed myself.
Thank you for considering my tips and I hope that I helped.

from vodle.

mensch72 avatar mensch72 commented on May 26, 2024

Hi @Wojtekb30 , thank you for your considerations!

I am a little confused by your statement that the base image be too small. The png file src/assets/topleft_icon.png which is used has a width of 784 pixels, which is surely larger than the size it will be rendered in in the top left corner on any device I can imagine, or isn't it?

Anyway, I tested replacing it with an svg version, and that works well. I should have thought of this trivial solution myself, I actually don't know why I didn't.

So the issue is solved, thank you for helping out!

from vodle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.