Auth - Response Code check about pigskin HOT 4 CLOSED

@OnceUponALoop Thanks for the compliments. :-) I just wish I had more time!

As for your question: there's no special reason I don't check for response codes; I just havn't gotten to it yet. There's a few todo/comments around saying I should add exactly that, and I would like it to be a feature of all requests.

So if you're motivated, submit a patch and I'll be happy to merge it. :-)

One thing that I wonder is whether this should be added as boilerplate to every function/method, or if there's a way a callback can be (sanely) added to the session handle, so that it becomes a standard feature of all connections. I'm not if such a setup would even be useful, but is something I was considering. Going that route opens up lots of possibilities beyond error checking, such as retries, logging, filtering, etc (#14, #17, #25 could be relevant). So it's a bit of a rabbit hole. ;-)

Thanks for the question, and if you have the time and energy, it would be great to see a PR. :-D

---Alex

-edit- (added issue numbers)

from pigskin.

I thought about this topic myself.

@aqw what do you think about extending the store() class? Like adding get() and post() methods to handle HTTP requests. Exceptions and HTTP errors would be handled there as well.

from pigskin.

Hey @jm-duke,

It's been awhile since I looked at this, but I think we can avoid having to extend the store class, since it's already contains the handle to the requests session. I /think/ we can just wrap/decorate/whatever the session handle, and it'll do everything we need to.

I think that would be the preferred solution (assuming it's possible). But if you find another way that you like and think is clean, then I'm all for it. :-)

---Alex

from pigskin.

Closing this issue, as NFL has canceled the Gamepass service

from pigskin.