.gz files not removed after deploy about grunt-s3 HOT 6 CLOSED

i think your issue is with css files correct? for me it helped when defined the src-files including suffix like that:

  src: "dist/**/*.css"

from grunt-s3.

For me it is every file I upload (for example, examples/*/):

https://github.com/mobify/mobifyjs/blob/v2.0/Gruntfile.js

from grunt-s3.

Hey @jansepar, that is definitely not intended. The .gz files should be cleaned up after they're uploaded (see https://github.com/pifantastic/grunt-s3/blob/master/tasks/lib/s3.js#L182). If that's not happening, there are 2 possible issues. The upload is failing midway through (although it should still delete the file), or there is simply a bug in the logic that cleans up the file.

I think a better approach would be to either write the file to /tmp before uploading, or even better, to stream the file and avoid writing to disk entirely.

from grunt-s3.

Hmmm, those files are sticking around for me still even without failing. If I get some time I can look into debugging it. Also feel free to checkout my repo to see if you can reproduce!

from grunt-s3.

Hey @jansepar, are you still having this problem? I checked out mobifyjs locally and everything seemed to work as expected.

I still believe that using a temp directory is a better solution.

from grunt-s3.

Thanks for having a look! I cleaned up the gz files and ran it again, and this time the files didn't stick around! I'm thinking last time it happened maybe there was an error with the deploy that I didn't notice, and some cleanup process didn't take place. So yeah I think in that scenario a temp directory would have been great. Thanks for looking into this!

from grunt-s3.