Caddy v0.10.12 cannot build with this plugin about caddy-grpc HOT 13 CLOSED

@mholt

How will it affect the Caddy build server if I use a vendor directory for the plugin. I'm thinking of telling dep to point to an older version of the upstream grpc-go to avoid surprises like these: mwitkow/grpc-proxy#24

from caddy-grpc.

Hmm, I'm not sure I would vendor Caddy itself either... 🤔 💣

from caddy-grpc.

I made some changes (added vendor then removed again :) don't ask), but the main change I made was to hard fork the proxy package from https://github.com/mwitkow/grpc-proxy into the plugin. There is a PR hanging there that will fix the mwitkow/grpc-proxy/proxy/handler.go:63:30: undefined: transport.StreamFromContext error mentioned above but I made that changes inside the plugin until the PR has been merged.

However now it seems the build is broken because of the new Cloudflare DNS as @mholt mentioned above.

from caddy-grpc.

Caddy v0.10.13 is ok! thanks!

from caddy-grpc.

This was fixed in #2, maybe caddy is hardcoded to partical version of caddy-grcp plugin?

from caddy-grpc.

thanks @shaxbee, I'm newbie in Go, is it possible to download caddy and the fixed plugin separately?

from caddy-grpc.

@bianbian-org I have a Dockerfile that shows how to build Caddy and plugins on your own: giantswarm/docker-caddy/Dockerfile

@shaxbee Thanks for the fix! \o/ I also hit that before. But now there is another one:

../../../mwitkow/grpc-proxy/proxy/handler.go:63:30: undefined: transport.StreamFromContext

from caddy-grpc.

Ok, it's probably because of this change, in a dependency introduced in November:

// We require that the director's returned context inherits from the serverStream.Context().

from caddy-grpc.

(And now Cloudflare's new DNS service broke one of our tests, go figure -- so deploying an update to the plugin will fail, but as soon as I get the next Caddy release out, later this week or early next, it should work.)

from caddy-grpc.

@pieterlouw As long as you don't vendor a lib used by Caddy, it should be OK. However, I haven't thoroughly tested it, but I think it works. (Or at least, it used to!)

from caddy-grpc.

Thanks @mholt. I just ran dep init on the plugin and it added caddy as one of the constraints.

[[constraint]]
  name = "github.com/mholt/caddy"
  version = "0.10.12"

Also, it added quite alot of packages to the vendor directory which might be included in caddy as well.
I'll see if there's a way around this.

from caddy-grpc.

Sorry, I've been a little delayed on that release, (end of semester stuff), but I will try to get it out soon.

from caddy-grpc.

Hi @bianbian-org. I've manage to deploy the latest code to Caddy (Thanks @mholt!), please check to see if this issue is resolved.

from caddy-grpc.