Giter Club home page Giter Club logo

Comments (8)

pierpo avatar pierpo commented on May 31, 2024 2

Thanks @robinvenneman for handling this.
I'll have to dive into this and think this through as well. Sorry about all these issues 😄

As always, your PR is very welcome 😊

from react-archer.

pierpo avatar pierpo commented on May 31, 2024 2

So indeed there is a mistake in the relationsWithStringifiedLabels, it only compares labels right now (which was not intended).

But even fixing it raises another issue: when you change a relation from one arrow to point to another element, the previous relation is not removed.

I have a solution for this, I'll try to implement it asap!

from react-archer.

robvenn avatar robvenn commented on May 31, 2024 1

@AlisonWonderlandApps Yeah I've fixed dynamically adding / removing elements and adding or removing relations by updating the props... I will open a PR soon, just haven't completely figured out that relationsWithStringifiedLabels check yet.

from react-archer.

pierpo avatar pierpo commented on May 31, 2024 1

This PR #25 should solve it 😊

from react-archer.

pierpo avatar pierpo commented on May 31, 2024 1

Fix published, tell me if you still have issues 😉

from react-archer.

DeveloperAlly avatar DeveloperAlly commented on May 31, 2024 1

awesome! Will check it out! Thanks both!

from react-archer.

DeveloperAlly avatar DeveloperAlly commented on May 31, 2024

@robinvenneman & @pierpo I'm having this same issue... did you have a workaround on forcing the arrows to re-render once they get a new relation? (code snippet would be great!)
My issue is that I have several different graphs to display in different tabs, but the arrows only render correctly for the FIRST display.
I also cannot manually draw arrows between 2 nodes by adding a new relation to the graph once already rendered :(
Any suggestions or help would be appreciated!!!

from react-archer.

robvenn avatar robvenn commented on May 31, 2024

Great job @pierpo thanks! A bit different from my solution but it works perfectly.

from react-archer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.