Improvements: fillMode as Enums about player HOT 8 CLOSED

hey @confile that's a nice idea.

from player.

@piemonte Player is a really great lib. Thanks for sharing.
Are there any other fillModes supported right now. Like aspect fill?

from player.

(I know it's a bit old, but may help)

@confile AVFoundation defines 3 constants:

AVLayerVideoGravityResizeAspect
AVLayerVideoGravityResizeAspectFill
AVLayerVideoGravityResize

More Info: https://developer.apple.com/library/prerelease/ios/documentation/AVFoundation/Reference/AVFoundation_Constants/index.html#//apple_ref/doc/constant_group/Video_Gravity

from player.

@piemonte Has this been implemented? I'd like to jump into open source and this seems a simple enough addition.

from player.

hey @matthewspear thanks for checking in. i'm swamped with some other things so feel free to submit a PR. contributions are always welcome. ✌️

from player.

Quite new to submitting to OS projects - How does this look?
I took inspiration from the way a UIImageView handles content mode:

public enum FillMode: String
{
    case resize = "AVLayerVideoGravityResize"
    case resizeAspectFill = "AVLayerVideoGravityResizeAspectFill"
    case resizeAspectFit = "AVLayerVideoGravityResizeAspect"
}

one other alternative would be to just use resize, aspect, aspectFill, which would you prefer?

Can make a pull request once happy with preference or have any other ideas!

Matt

from player.

Hey @matthewspear apologies, i didn't see your last comment. The way you have it is great, I'll just paste it into the class and give you props in the comment.

from player.

👍

from player.