Giter Club home page Giter Club logo

Comments (2)

do-adams avatar do-adams commented on June 24, 2024

I agree, this seems like bad practice. This CSS makes it impossible to properly render nested HTML content within the .device-content block of the .device.

I managed to fix this by modifying the base devices.css styles with this:

.device,
.device::before,
.device::after,
.device > *,
.device > * > *,
.device > *::before,
.device > *::after,
.device > * > *::before,
.device > * > *::after {
  box-sizing: border-box;
  display: block;
}

It works well so long as the device structure follows the pattern (which all of the devices as of v0.1.16 do):

<div class="device device-iphone-x">
  <div class="device-frame">
    <img class="device-content" src="...">
  </div>
  <div class="device-stripe"></div>
  <div class="device-header"></div>
  <div class="device-sensors"></div>
  <div class="device-btns"></div>
  <div class="device-power"></div>
</div>

I hope this helps anyone else who's running into the same issue!

from devices.css.

aaarichter avatar aaarichter commented on June 24, 2024

I ran into the same issue with https://github.com/picturepan2/devices.css/blob/master/src/_reset.scss#L3 setting display:block to every element. If you want to set markup inside the content this can break the content UI.

from devices.css.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.