Giter Club home page Giter Club logo

Comments (4)

joshuadegier avatar joshuadegier commented on August 20, 2024 1

Looks like the API doesn't support looking up an administration based on ID such as other Entities do: https://developer.moneybird.com/api/administration/.

I don't see any ways to make this work unless there is an extra call in Picqer\Financials\Moneybird\MoneyBird that saves the list of administrations on each request. But that would add a single request each time you use the API while fetching that data is not needed in every request. I think you're best off by caching the $moneybird->administration()->getAll() response with the administration id as key and make your own implementation to fetch the details afterwards.

from moneybird-php-client.

hiranthi avatar hiranthi commented on August 20, 2024

And here I thought I was missing something, because after setting the administrationId listing the administrations didn't work anymore. Good to know I was not.

from moneybird-php-client.

donquixote avatar donquixote commented on August 20, 2024

The solution is to give Administration a different Connection object than other models:

  • Administration needs a connection without administration id.
  • Other models need a connection with administration id.

Here is what I currently have locally:

class Administration extends Model {

    [..]

    /**
     * @param \Picqer\Financials\Moneybird\Connection $connection
     * @param array $attributes
     */
    public function __construct(Connection $connection, array $attributes = [])
    {
        parent::__construct($connection->withoutAdministrationId(), $attributes);
    }
}

What I changed:

  • Add a few "wither" methods to Connection, which clone the connection and set properties of the clone, hence making it behave like an immutable object. This makes it easy for Administration to use its own version of Administration.
  • Override the constructor for Administration, to use a different Connection object.

from moneybird-php-client.

donquixote avatar donquixote commented on August 20, 2024

Looks like the API doesn't support looking up an administration based on ID such as other Entities do: > https://developer.moneybird.com/api/administration/.

$moneybird->administration()->get() works for me to fetch all administrations, after the change explained above.

from moneybird-php-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.