[Help wanted] How to check for success of the delete() function? about moneybird-php-client HOT 5 CLOSED

The Moneybird API is designed to behave like this, so the client mirrors it: http://developer.moneybird.com/api/contacts/#delete_contacts_id

Deleting a contact returns a 200 OK status with the full object, where you might expected either a failure (in case of no removal) of a 204 response. I don't think we should change the client to behave differently. You could contact Moneybird and ask them about this design and their solution to detect removal. I think at this time you cannot without an extra call.

from moneybird-php-client.

I have, I'm awaiting their response. It just seems so wasteful. Besides there are quite some inconsistencies in the API anyway, so who knows.

from moneybird-php-client.

Verbatim:

<snip>
Bedankt voor je email. Het is nu inderdaad niet handig om te achterhalen of het verwijderen van een contact geslaagd is. Ik heb hiervoor zojuist de nodige wijzigingen gemaakt in onze API zodat we voortaan een 422 met foutmelding teruggeven als het verwijderen mislukt. Dit zal waarschijnlijk morgen live gaan.
<snip>

So a 422 response when the action fails.

from moneybird-php-client.

When we do #55 we will be able to check the ApiException on code 422.

from moneybird-php-client.

Seems already done by you in #54 :)

from moneybird-php-client.