Comments (4)
Hard to choose :)
While proposal 2
looks great, it also somewhat overwrites the perception of the off
state. Because we lose the background. Proposal 1
could also be the same way, because the dot color changes.
In the end, this is to notify the user about the invalid form, we have red outlines for checkboxes, inputs and so on, and this is only temporary to block the user, so may be just go with the actual
?
from pico.
Not sure 🙂
Maybe proposal 2:
https://codepen.io/picocss/pen/zYdZyQB
from pico.
At least there is no bug anymore. It's just a style preference, and it's quite easy to customize for users.
I will keep this issue open. Maybe there will be other comments.
The need for validation states on a switch is also probably uncommon.
from pico.
Glad the bug is gone, I will do a fresh pull shortly. It's actually uncommon, but who knows there might be a time where a lost soul does some server side validation or conditional things with yup and then need to trigger an error state. Who knows... :)
Please feel free to close at your convenience.
from pico.
Related Issues (20)
- Grid with inputs has incorrect gap on mobile devices HOT 3
- Modal component is relying too much on Javascript HOT 9
- Input shadows are offset incorrectly in Firefox HOT 2
- Unable to use on Hugo v0.122.0 via Dart Sass HOT 5
- SassError: "This variable was not declared with !default in the @used module" HOT 3
- v2: inconsistent switch states HOT 5
- Spinner not fully visible in the `<code>` element HOT 1
- `nav li button[type="button"]` does not have smaller padding HOT 1
- node version restriction HOT 7
- Inconsistent width with role=group HOT 1
- Buttons with overflowing alpha-numeric text do not wrap HOT 1
- Unhandled overflow behaviour on dropdown LI elements
- Detected Trojan:Script/Wacatac.B!ml in latest downloads HOT 4
- Accordion within Card footer is vertically not aligned.
- Inputs in dropdown are not accessible via keyboard nav
- `<a role="button">` is not vertically aligned with `<button>` in `<nav>` HOT 1
- Table has unexpected background color when in `<article>` in dark theme
- Dropdown is not vertically aligned with `<a>` in `<nav>` HOT 2
- Selecting another radio has a flash of white in dark mode
- Version 2 cards have almost no padding HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pico.