Giter Club home page Giter Club logo

Comments (6)

lucaslarroche avatar lucaslarroche commented on June 2, 2024 2

@gp-slick-coder, do you recommend updating the docs? Or removing the feature (not possible now to avoid a breaking change).

I guess it could be useful for a group of related actions, like:
image

from pico.

Brian-Pob avatar Brian-Pob commented on June 2, 2024 1

What about something like this where the whole border of the button in the group is shown instead of a broken border?

CleanShot.2024-02-17.at.01.40.44.mp4

Example from:
https://stackoverflow.com/a/67756667

from pico.

Brian-Pob avatar Brian-Pob commented on June 2, 2024 1

The issue with the button group overflowing seems to be due to this style rule setting a new horizontal padding of 2rem, which overrides the original horizontal padding of 1rem.

[role=group] [role=button], [role=group] [type=button], [role=group] [type=submit], [role=group] button, [role=search] [role=button], [role=search] [type=button], [role=search] [type=submit], [role=search] button {
    --pico-form-element-spacing-horizontal: 2rem;
}

image

It seems that keeping the padding at 1rem still looks decent while allowing the display to get as small as 306px (smaller than an iPhone SE at 375px) without any overflow issues. See attached screen recording

Recording.2024-02-18.162102.mp4

from pico.

gp-slick-coder avatar gp-slick-coder commented on June 2, 2024

Sorry for my bad description. The feature is useful. The only issue is with the focus of the button(s).

Current behavior: On a button click, all buttons will be "focused" (as shown in the previous image).

Expected behavior: On a button click, only the button that was clicked, should be focused.

Good examples:
https://efrolic.github.io/css//button-group
https://bulma.io/documentation/elements/button/#button-addons
https://picturepan2.github.io/spectre/elements/buttons.html#buttons-groups
https://getbootstrap.com/docs/4.0/components/button-group/

from pico.

lucaslarroche avatar lucaslarroche commented on June 2, 2024

Ah, yes, I get it.

I think this style looks broken/buggy:
Screenshot 2024-02-13 at 23 17 21
Screenshot 2024-02-13 at 23 18 09
Screenshot 2024-02-13 at 23 24 46

I still prefer this style:

Screen.Recording.2024-02-13.at.23.21.11.mov

But I'm open to a better solution.

from pico.

fadrian06 avatar fadrian06 commented on June 2, 2024

I am having overflow problems on mobile

Screenshot_20240217-132912.png

The third button of the group leaves the container

from pico.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.