Breaking Change: Moving Namespaces and assemblies to PicklesDoc.* about pickles HOT 7 CLOSED

I committed this change earlier today. Please let me know if you notice problems.

from pickles.

I see this changes the name of the CommandLine exe emitted to PicklesDoc.Pickles.CommandLine.exe . I know this is going to affect us. Do you think it would be better to change this to continue to produce Pickles.CommandLine.exe?

from pickles.

The refactor might have renamed the assemblies too? What do you think Dirk?

I'm not at a computer with VS installed right now, will look at it tonight
if I can.

On Thu, Nov 29, 2012 at 10:04 AM, aaronjrich [email protected]:

I see this changes the name of the CommandLine exe emitted to
PicklesDoc.Pickles.CommandLine.exe . I know this is going to affect us. Do
you think it would be better to change this to continue to produce
Pickles.CommandLine.exe?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/22#issuecomment-10850329.

from pickles.

Hi,

Fact: yes, I renamed the assemblies as well during the refactoring. My main reason: the fact that the namespace changes, makes it necessary to change any MSBuild script that references the Pickles task. And if I change one assembly name, then I might as well change all of them.

However: I would actually be in favour of simplifying the assembly names of the runners. For example:

• [PicklesDoc].Pickles.CommandLine.exe: I'd like to simply call this "pickles.exe"
• [PicklesDoc].Pickles.UserInterface.exe: I'd like to simply call this "picklesui.exe"

What do you two think about that?

from pickles.

Agreed!

On Thu, Nov 29, 2012 at 10:47 AM, dirkrombauts [email protected]:

Hi,

Fact: yes, I renamed the assemblies as well during the refactoring. My
main reason: the fact that the namespace changes, makes it necessary to
change any MSBuild script that references the Pickles task. And if I change
one assembly name, then I might as well change all of them.

However: I would actually be in favour of simplifying the assembly names
of the runners. For example:

• [PicklesDoc].Pickles.CommandLine.exe: I'd like to simply call this
  "pickles.exe"
• [PicklesDoc].Pickles.UserInterface.exe: I'd like to simply call this
  "picklesui.exe"

What do you two think about that?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/22#issuecomment-10853109.

from pickles.

I renamed the executables. @aaronjrich, are the names proposed by Dirk OK for you? If so then we can go ahead and close this issue.

from pickles.

Agreed, nice and simple. We'll just have to update our build definitions to use the new naming scheme. Maybe I should make that configurable. Thanks.

from pickles.