Giter Club home page Giter Club logo

Comments (6)

PowerKiKi avatar PowerKiKi commented on May 10, 2024 1

Finally pushed my work. Examples/ was moved to samples/ and mimic as much as possible what is done for PhpPresentation.

Compared to PhpPresentation, I moved some logic from Header.php to a dedicated class \PhpSpreadsheet\Helper\Sample. That seemed cleaner. And it is also used in unit tests to get the complete list of samples. Meaning that all samples are now ran by phpunit. Or almost all of them, because I noticed a few of them crashed. I'll open separate issue for those.

One last thing to do would be to move Documentation/Examples into the same structure, most likely keeping the folder structure and re-organizing existing sample in folders too. And finally reflect this folder structure in the menu on the web interface, to have some kind of categories.

from phpspreadsheet.

MarkBaker avatar MarkBaker commented on May 10, 2024

Fixed typehinted arguments where null values being passed to methods, allowing null as defaults

from phpspreadsheet.

PowerKiKi avatar PowerKiKi commented on May 10, 2024

I'd like to help you with that. If not completed already I could finish the example updates, and I had in mind to use phpunit to make sure that all examples can actually be run (no actually testing the results, but at least that they run without errors). What do you think ? Or would you rather finish this by yourself ?

from phpspreadsheet.

Progi1984 avatar Progi1984 commented on May 10, 2024

@PowerKiKi You can use the template HTML/JS/CSS that I made for PhpPresentation for samples.

https://github.com/PHPOffice/PHPPresentation/blob/develop/samples/Sample_Header.php#L419
https://github.com/PHPOffice/PHPPresentation/blob/develop/samples/Sample_Footer.php

from phpspreadsheet.

PowerKiKi avatar PowerKiKi commented on May 10, 2024

Forgot to mention that I am working on that. Using PHPPresentation as foundation.

from phpspreadsheet.

Progi1984 avatar Progi1984 commented on May 10, 2024

@PowerKiKi Perfect ;)

from phpspreadsheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.