Giter Club home page Giter Club logo

Comments (3)

Synchro avatar Synchro commented on May 10, 2024

I agree that it is unnecessary to set reply-to - it's only needed if it's different to the from address, yet here it's guaranteed to always be the same.
I'm not sure the same can be said for setting the sender.
As far as orthogonality goes, SetFrom is a convenience wrapper for setting From, FromName and Sender manually and having it do some other stuff automatically can make for simpler code overall. If you want finer control, you can always set them manually and just not call SetFrom.
In the same vein, I'm thinking of having MsgHTML normalize line breaks to CRLF; the vast majority of emails I see made with phpmailer use wrong line breaks to their detriment, so it would be consistent to have a convenience function do some cleaning up.

from phpmailer.

Synchro avatar Synchro commented on May 10, 2024

I've removed the creation of the unnecessary reply-to, but I think setting Sender is generally a good idea, and it won't interfere with manual overrides, so I've kept that along with 'auto' mode. That ok with you?

from phpmailer.

ooxi avatar ooxi commented on May 10, 2024

Yes that's great!

from phpmailer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.