Comments (8)
Can we run some benchmark?
Thanks :) ..
from php-src.
Thank you! I have copied over the description from the old bug tracker. @nikic's question remains unanswered:
Why is this order better?
I think I understand your point, but does the order of the checks really matter for userland developers? After all, they need to fix the function call. And for the implementation, the current way is likely the most convenient and fastest.
from php-src.
Adding another check seems pointless. It would just add a slowdown for no particular reason.
from php-src.
The slowdown will be very minimal.
from php-src.
The slowdown will be very minimal.
Is that so?
from php-src.
The slowdown will be very minimal.
How do you know ?
from php-src.
That is my guess. I am not C developer so I cannot verify this easily. Can we run some benchmark?
from php-src.
The way I see it, speaking for myself. Not voting yes for this, I see no benefits and surely not perf improvements.
from php-src.
Related Issues (20)
- setTimestamp sets the wrong value HOT 2
- Integer overflow on stream_notification_callback byte_max parameter with files bigger than 2GB HOT 1
- Link latest sqlite3 library into php_sqlite3.dll, php_sqlite3.so HOT 4
- array_diff weirdness HOT 5
- The ldap extension cannot be built on Solaris with Oracle Instant Client HOT 19
- PCRE pattern cache crashes process in wrapper stream_close called after shutdown HOT 2
- 8.4.0alpha2 fails to build: `error: redefinition of typedef ‘zend_string’` HOT 13
- BUG : Compiling opcache extensions statically into ZTS PHP , JIT bug HOT 6
- In Czech function have bad order with diacritic HOT 11
- IntlChar::foldCase()'s $option is not optional HOT 3
- Support typed variables HOT 3
- The `IntlChar::getBidiPairedBracket()` method is not defined HOT 2
- Add support for all flags from mysql in the PDO MySql driver in the getColumnMeta function.
- php_random_default_engine() is not C++ conforming HOT 4
- PHP interpretor stops on ?> inside comment HOT 10
- _ir_RSTORE: Assertion `ctx->control' failed HOT 3
- Segmentation fault (core dumped) in ext/pgsql/tests/gh13519.phpt HOT 10
- Memory issues yield vs yield from HOT 4
- Compiling php_random_pcgoneseq128xslrr64_rotr64() triggers C4146 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-src.