Comments (6)
I pushed 8.3.9 to our users with the cache variables set yesterday morning. I haven't heard anything yet, but I think that should fix this particular issue. I switched to the system libgd at the same time and took advantage of the cache variables there, too. Thanks for all the work you did to make this work.
from php-src.
Cross-compiling in PHP needs a lot of improvements indeed. Yes, all those checks should be wrapped in AC_CACHE_CHECK so the php_cv_* variables can be passed manually to help the configuration step determine the platform.
About these crypt algorithms checks I'm not sure how else could they be determined but to run the test program. Probably we can start filtering the platforms in case of cross-compiling and pass those that are certain to have these.
from php-src.
Thanks, I think using the cache variables is a fine approach where no better way to write the checks is apparent. I'll work on caching the format checks for the system libgd, and then afterwards solve both problems by overriding the cache variables.
from php-src.
The libgd checks can be done like this: #14443
I'm still fixing two AC_RUN_IFELSE checks in fpm and two left overs in configure.ac.
Yes, to cross-compile (for the time being) can be done like this:
./configure --host=<target-triplet> --enable-gd --with-external-gd \
php_cv_lib_gd_gdImageCreateFromPng=yes \
php_cv...=...
from php-src.
The libgd checks can be done like this: #14443 I'm still fixing two AC_RUN_IFELSE checks in fpm and two left overs in configure.ac.
Oh, you already did it, thank you!
from php-src.
Just a quick update here because changing everything takes several steps. So far many AC_RUN_IFELSE checks were wrapped in the AC_CACHE_CHECK so the cache variables can be used. The external libcrypt simplifications are done in this PR: #14791 which introduces a new single cache variable for all required crypt algos: php_cv_lib_crypt_algos=yes|no
instead of setting 6 cache variables just for the external crypt library.
And what I'd suggest for the time being is to go with these. These run checks cannot be changed to link or compile checks at this point I believe. If you find anything else to simplify or if some known platform can directly override some check and can skip setting the cache variable, please send a PR or open an issue for that. This will be further checked in the future also if more simplifications are possible.
from php-src.
Related Issues (20)
- filesize() returns false on symlink HOT 8
- Set file creation/change time in touch HOT 2
- FPM doesn't log events where no more children are available with static config
- Failed to make extensions `mysqli` HOT 9
- php-fpm process: SQLSTATE[HY000] [2002] Connection timed out with database HOT 3
- Segmentation fault in zend_mm_alloc_small, heap->free_slot corrupted HOT 3
- curl_error() is missing a fallback as expected and documented in curl manual HOT 2
- pdo_mysql not returning int for `sum` aggregate function HOT 10
- PHP 8.3: "yield /*comment*/ from" is no longer a parse error ? HOT 23
- Custom stream wrapper dir_readdir output truncated to 255 characters in PHP 8.3 HOT 6
- .
- Bison parser generates different zendtokentype constants for each patch version since php 8.3. HOT 2
- strtr doesn't strip the pipe character (PHP 8.2.20) HOT 1
- Invalid PHP header with PHP.INI expose_php = On HOT 2
- Comments between object operator and semi-reserved name result in parse error
- bug loop in php HOT 1
- Crash on coercion with throwing __toString()
- Unknown addr size on arm64 at MSVC 19.41.34115.96 HOT 9
- Proposal: Dump circular references in var_export() using IIFE HOT 7
- magic property guards are not reset in timeout HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-src.