Can't cross-compile with external libcrypt about php-src HOT 6 CLOSED

I pushed 8.3.9 to our users with the cache variables set yesterday morning. I haven't heard anything yet, but I think that should fix this particular issue. I switched to the system libgd at the same time and took advantage of the cache variables there, too. Thanks for all the work you did to make this work.

from php-src.

Cross-compiling in PHP needs a lot of improvements indeed. Yes, all those checks should be wrapped in AC_CACHE_CHECK so the php_cv_* variables can be passed manually to help the configuration step determine the platform.

About these crypt algorithms checks I'm not sure how else could they be determined but to run the test program. Probably we can start filtering the platforms in case of cross-compiling and pass those that are certain to have these.

from php-src.

Thanks, I think using the cache variables is a fine approach where no better way to write the checks is apparent. I'll work on caching the format checks for the system libgd, and then afterwards solve both problems by overriding the cache variables.

from php-src.

The libgd checks can be done like this: #14443
I'm still fixing two AC_RUN_IFELSE checks in fpm and two left overs in configure.ac.

Yes, to cross-compile (for the time being) can be done like this:

./configure --host=<target-triplet> --enable-gd --with-external-gd \
  php_cv_lib_gd_gdImageCreateFromPng=yes \
  php_cv...=...

from php-src.

The libgd checks can be done like this: #14443 I'm still fixing two AC_RUN_IFELSE checks in fpm and two left overs in configure.ac.

Oh, you already did it, thank you!

from php-src.

Just a quick update here because changing everything takes several steps. So far many AC_RUN_IFELSE checks were wrapped in the AC_CACHE_CHECK so the cache variables can be used. The external libcrypt simplifications are done in this PR: #14791 which introduces a new single cache variable for all required crypt algos: php_cv_lib_crypt_algos=yes|no instead of setting 6 cache variables just for the external crypt library.

And what I'd suggest for the time being is to go with these. These run checks cannot be changed to link or compile checks at this point I believe. If you find anything else to simplify or if some known platform can directly override some check and can skip setting the cache variable, please send a PR or open an issue for that. This will be further checked in the future also if more simplifications are possible.

from php-src.