Giter Club home page Giter Club logo

Comments (5)

tiffany-taylor avatar tiffany-taylor commented on July 21, 2024

FWIW, I'm hesitant to make it a warning because I don't want to discourage usage of random_bytes, but I believe it should be noted in some form so that it doesn't come as a surprise.

from doc-en.

kamil-tekiela avatar kamil-tekiela commented on July 21, 2024

Why should this be a warning? Doesn't "bytes" already mean "all bytes"? If you feel a need to clarify this in the manual then I don't it needs to be a warning.

from doc-en.

tiffany-taylor avatar tiffany-taylor commented on July 21, 2024

Removed the "warning" wording because, agreed, it shouldn't be a warning, but I think it should be noted at least.

from doc-en.

salathe avatar salathe commented on July 21, 2024

Can you elaborate on why null bytes deserves special mention for this function? We don't ordinarily do that for other functions whose return value can contain null bytes.

from doc-en.

gnif avatar gnif commented on July 21, 2024

I also agree with other replies here, there is no need to document that null bytes are possible, this is implied by the type "byte" being an 8-bit value from 0-255. All values in this range are valid byte values, including 0. If the function was random_char or similar then it would warrant such warnings, but this is not what it is.

from doc-en.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.