Giter Club home page Giter Club logo

Comments (2)

julienfalque avatar julienfalque commented on June 12, 2024

I think this should use the (string) cast to keep the same behavior:

-$a = "{$msg}";
+$a = (string) $msg;
-$a = "{$obj->msg}";
+$a = (string) $obj->msg;
$a = "{$msg} "; // do nothing, complex string consists of more than a variable

Why would this be limited to complex strings though? Couldn't the fixer also fix

-$a = "$msg";
+$a = (string) $msg;

?

should this be part of single_quote fixer?

I don't think so, this looks like an entirely new feature to me and I would create a new fixer.

from php-cs-fixer.

mvorisek avatar mvorisek commented on June 12, 2024

Good point with the cast. I did not realized it when I was opening this issue. I probably do not want to pursue this issue then and simply find and fix issues in our codebase using "\{\$.+\}" regex.

from php-cs-fixer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.