Giter Club home page Giter Club logo

Comments (13)

videlalvaro avatar videlalvaro commented on July 19, 2024

what do you think the default QOS should be?

from rabbitmqbundle.

tcz avatar tcz commented on July 19, 2024

As of me, I don't need prefetch (or maybe a prefetch count 1) because I work with small messages but I might launch multiple consumers.

from rabbitmqbundle.

asm89 avatar asm89 commented on July 19, 2024

The default QoS as defined by RabbitMQ assumes that the client has an unlimited buffer, so it will send out as much messages as it can to the client. If you want to add multiple consumers to a queue, but one of the consumers already has all the messages in its buffer the new consumers will remain idle.

Maybe it's an idea to add qos.prefetch_size and qos.prefetch_count options to the consumer configuration? The base consumer can set appropriate options for the channel.

from rabbitmqbundle.

videlalvaro avatar videlalvaro commented on July 19, 2024

I will look into this or someone can start writing a patch ;)

from rabbitmqbundle.

asm89 avatar asm89 commented on July 19, 2024

I can probably write up a patch for this, but it's probably a good idea to have #50 merged first. ;)

from rabbitmqbundle.

videlalvaro avatar videlalvaro commented on July 19, 2024

We are working on getting that merged ASAP :)

from rabbitmqbundle.

videlalvaro avatar videlalvaro commented on July 19, 2024

@asm89 you are good to go ;)

from rabbitmqbundle.

asm89 avatar asm89 commented on July 19, 2024

Would you still like a PR for this? Do you like the parameters I suggested above?

from rabbitmqbundle.

videlalvaro avatar videlalvaro commented on July 19, 2024

Sorry I've been off for a while. Yes I want a patch

from rabbitmqbundle.

onchainguy-eth avatar onchainguy-eth commented on July 19, 2024

We implemented configurable QOS support so that the developer is able to set prefetch_size and prefetch_count for each consumer.

See https://github.com/videlalvaro/RabbitMqBundle/pull/64

from rabbitmqbundle.

videlalvaro avatar videlalvaro commented on July 19, 2024

@tcz can we close this issue?

from rabbitmqbundle.

tcz avatar tcz commented on July 19, 2024

Hi,

I did not have the opportunity to test this but I'm sure it works. Thanks!

from rabbitmqbundle.

videlalvaro avatar videlalvaro commented on July 19, 2024

@tcz seems legit :P

from rabbitmqbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.