'tokio-runtime-worker' panicked at 'not zero terminated' about timetrackrs HOT 10 CLOSED

looks like the WM_CLASS of some window looks different than expected.. if you can identify from which window it comes that would be helpful (you can use xprop |grep WM_CLASS to find out the wm class of programs, should be two strings

from timetrackrs.

So far I "fixed" it commenting out the panic:

// "2\u{0}4\u{0}5\u{0}6\u{0}8\u{0}9\u{0}1\u{0}" to array of strings
pub fn split_zero(s: &str) -> Vec<String> {
    let mut vec: Vec<String> = s.split('\0').map(String::from).collect();
    // let last = vec.pop().unwrap();
    // if !last.is_empty() {
    //     panic!("not zero terminated");
    // }
    vec
}

from timetrackrs.

and yes:

❯ xprop | grep WM_CLASS                     
WM_CLASS(STRING) = "konsole", "konsole"

from timetrackrs.

that konsole string looks fine - it could be in another window. maybe you could add a log::warn!("unexpected class: {vec:#?}") in the if !last.is_empty()?

from timetrackrs.

Ok, I guess it happens because of my custom desktop names:

from timetrackrs.

uh, that's weird that those are in the window class though - can you say which window manager and status bar etc you are using?

from timetrackrs.

bspwm and polybar

from timetrackrs.

and I think it called from here: let desktop_names = split_zero(&get_property_text(..., so desktop names

from timetrackrs.

ah, i forgot that that function is also used there. I guess the panic should only apply to classes then, where it makes sense to strip out the last empty bit

from timetrackrs.

There seems to be an inconsistency in the way the string lists are created, bspwm not zero-terminating the list. I've added a check that only removes the last element if it is empty, this should fix it. Let me know if you still encounter this issue.

from timetrackrs.