Comments (7)
CaffeineMC/phosphor-fabric#13 (comment)
Someone told me this is due to phosphor and lighting-fixes being incompatible, gudFPS just makes it crash on launch.
I will close this issue now, sorry to bother.
from mc-fixes.
We are working on a fix for the compatibility issue. The current plan is to include my code into Phosphor, but we don't have any ETA for that.
from mc-fixes.
With some brute force refactoring I was able to get custom builds of Phosphor and mc-fixes to launch together on Minecraft 1.16.1. I'm not sure if it really makes sense to include it as a pull request, especially if you're going to incorporate the fixes into Phosphor (and because I had to patch both mods), but I'll include the forks for people who want to use the mods together, at least as a temporary fix.
My only goal was compatibility, so I just preserved the original logic of both mods and tried to split them into smaller/less invasive mixins when I could. Ideally, the mods' behaviors and performance should be identical to their official counterparts. Phosphor for Minecraft 1.16.2 is not out yet, so I downgraded mc-fixes to work with Minecraft 1.16.1.
I'm not completely sure if the resulting lighting logic makes sense, but the game launches, no unexpected errors, performance seems to be good, and I haven't yet seen any new issues or glitches apart from maybe issue #1. Also, not sure if there would be compatibility issues anyway, but these custom builds of Phosphor and mc-fixes work with Sodium and Lithium as well, without any modifications necessary for Sodium or Lithium.
I was mainly inspired to work on this because not being able to use mc-fixes with Sodium/Lithium/Phosphor (and having huge lag spikes when crossing some chunk borders...) was incredibly painful, so thank you for creating these fixes in the first place. :)
mc-fixes: https://github.com/the6thdoor/mc-fixes
Phosphor: https://github.com/the6thdoor/phosphor-fabric
from mc-fixes.
Hi @the6thdoor . Feel free to join JellySquid's discord, which can be found on her Github repos, in case you want (and have time to) assist in porting the code 😃
I hope my frequent force-pushes to lighting-fixes
arent't too annoying :P That branch was primarily intended for personal use and I didn't have time yet to polish the setup, mainly due to some annoying Mixin and Loom bugs.
from mc-fixes.
Phosphor for Minecraft 1.16.2 is not out yet, so I downgraded mc-fixes to work with Minecraft 1.16.1.
mc-fixes: https://github.com/the6thdoor/mc-fixes
Phosphor: https://github.com/the6thdoor/phosphor-fabric
Would you mind updating your forks to make mc-fixes work with the newest phosphor version? I understand if it is too difficult/you don't have the time.
from mc-fixes.
Fortunately, I believe as of Phosphor 0.7, mc-fixes has been merged into Phosphor, so my forks shouldn't be necessary anymore.
from mc-fixes.
Fortunately, I believe as of Phosphor 0.7, mc-fixes has been merged into Phosphor, so my forks shouldn't be necessary anymore.
Ah, OK, cool!
from mc-fixes.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mc-fixes.