Phergie_Plugin_Remind Port about phergie HOT 6 CLOSED

Potential patch from Evan Fribourg (dotEvan):
diff -ur Phergie/Plugin/Remind.php Phergie_new/Plugin/Remind.php
--- Phergie/Plugin/Remind.php 2009-07-10 20:36:44.000000000 -0700
+++ Phergie_new/Plugin/Remind.php 2009-09-04 17:01:17.000000000 -0700
@@ -236,7 +236,7 @@
'time' => date(DATE_RFC822),
'channel' => $source,
'recipient' => strtolower($recipient),
- 'sender' => strtolower($nick),
+ 'sender' => $nick,
'message' => $message
));
} catch (PDOException $e) { }

from phergie.

I've actually solved this the other way around: while looking up if there are any messages left, do a strtolower( ) over the nick. Here's the diff:

$ svn diff Plugin/Remind.php 
Index: Plugin/Remind.php
===================================================================
--- Plugin/Remind.php   (revision 421)
+++ Plugin/Remind.php   (working copy)
@@ -262,6 +262,7 @@
      */
     protected function deliverReminders($channel, $nick)
     {
+        $nick = strtolower( $nick );
         if ($channel[0] != '#') {
             // private message, not a channel, so don't check
             return;

That seems to work like a charm. To clarify: Phergie is in use on three of the channels I frequent, and after a little debugging session we indeed figured out that it had something to do with the use of capital letters in the nick. My own nick never gave any issues, as it only contains lower-case characters, while other people were struggling. That behaviour seemed to be solved after adding the line mentioned in the diff.

from phergie.

Thanks for the report berry! Reminder hasn't been ported over to 2.x yet, but at least now we know what the cause of the issue is. :) We appreciate your contribution.

from phergie.

You're most welcome!

from phergie.

I've ported it over with fixes to the case-sensitivity issue.

http://github.com/jlogsdon/phergie/commit/03bb46c04e4ddc1f1a50497f208ab602e629a20a
http://github.com/jlogsdon/phergie/commit/0fb39f7ef50f4f85480ce18c75d3b3d66dea46a2
http://github.com/jlogsdon/phergie/commit/01555b1f21563586a675e493403266dd199a687c

I'm not really seeing a purpose for the in memory store, but I went ahead and just ported the whole thing.

from phergie.

Appears to be working great! Closing this ticket, thanks jlogsdon and everyone else who contributed!

from phergie.