Comments (4)
Ah, I think I see the issue: the <nick>
pattern in RFC 1459 Section 2.3.1, or more specifically the <special>
subpattern used by <nick>
, did not include the underscore as a valid character. However, it looks like <special>
was amended in RFC 2812 Section 2.3.1 to include the underscore.
No patterns other than <nick>
use <special>
, so the two are consolidated in the parser implementation. As such, fixing this should be as simple as adding an underscore (escaped with a double backslash since it's a regular expression metacharacter) to the $nick
pattern defined here: https://github.com/phergie/phergie-irc-parser/blob/master/src/Phergie/Irc/Parser.php#L209
I'll try to add a fix and corresponding unit test update this evening unless you care to beat me to it. :) Thanks for reporting this issue!
from phergie-irc-parser.
Alright, went ahead and added a fix for this and a testcase in a1d2359.
If you'd like, I can open a pull request for it.
You're welcome. :)
from phergie-irc-parser.
The changes look good, though because they and unrelated changes from PR #2 are both based on your master branch, github is confusing them. PRs are based on branches; if you want to amend a PR, you simply make more commits to its branch. If you base two PRs on the same branch, github has trouble following which changes are specific to which PR.
from phergie-irc-parser.
Actually, one small change: per my comment from PR #1, the added ACTION test case should be commented (which you've done) and moved above the FINGER test case (which still needs to be done). At that point, I can merge both PRs #1 and #2. In the future, please base each PR on its own branch. Thanks!
from phergie-irc-parser.
Related Issues (19)
- The message string requires \r\n HOT 2
- Provide a way to get at message constituent patterns
- Numeric parsing HOT 6
- Channel MODE parsing and multiple mode changes HOT 8
- parseAll() hangs if an invalid line is received HOT 7
- Valid hostnames HOT 2
- Resilience against invalid lines HOT 2
- Update README for next release
- Added .gitattributes to exclude unneeded files for packages
- RFC2812 USER command specification HOT 2
- $params['all'] strips off the leading colon if the first parameter is a trailing parameter HOT 2
- Some user hostnames can't be parsed HOT 21
- ZNC buffer playback messages are not picked up on HOT 4
- Parser output not correct on `PART #laravel` (without colon) HOT 10
- Drop Support for PHP 5.5
- Nickname regular expression is incorrect. HOT 3
- Crashing on CTCP messages HOT 3
- Add support for /part with comments HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phergie-irc-parser.