Giter Club home page Giter Club logo

Comments (3)

Gscorreia89 avatar Gscorreia89 commented on June 2, 2024

This particular bit has been removed, which means in theory it should be fine...
However, the helper function used in this report (batchCorrectionTest) is still expecting the dilution series to filter which features are passing dilution. I have removed these bits (see 3e259e9), which means now no filtering by dilution series should be done before (hence will work without dilution series). Will close after properly testing.

from npyc-toolbox.

jaketmp avatar jaketmp commented on June 2, 2024

Does this imply that features should be filtered on the LR before batch correction?

from npyc-toolbox.

Gscorreia89 avatar Gscorreia89 commented on June 2, 2024

To make it work for datasets without linearity reference - this has to be removed or made optional. What I will do before closing is try to refactor it a bit to be like the other reports - copy the dataset, and do an updateMasks(). The updateMasks method should handle flexibly whether or not we have LinearityReferences I think (if not then it will haha).

from npyc-toolbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.