Big Official 2.x to 3.x Upgrade List of Issues about muncie-events3 HOT 8 CLOSED

• Event form
  • "remove" buttons appear below input fields instead of beside them
  • "submit" button needs Bootstrap classes added
• Mailing list signup page
  • The "all events" option for "event types" is no longer selected by default
  • Checkboxes for event types aren't selected by default
  • Under "frequency", the weekly/daily options are missing and only the "custom" option is shown
• Other
  • A successful login doesn't redirect to home page, but just loads the login page again
  • The ME icon in the logo needs cursor: pointer
  • New JavaScript error: Lines like muncieEvents.populatedDates['11-2009'] = [01,06,08,15,22,25,27,29]; generate errors for numbers that start with zero. This could be adapted to remove the leading zeros, or these values could be changed to strings.
  • In image_manager.js, on line 242 (url: '/images/user_images/'+ImageManager.user_id,), something's not setting ImageManager.user_id and the URL ends up being .../null
  • /general (and other category pages) is showing events from all categories
  • I recommend copying code from https://github.com/BallStateCBER/datacenter-plugin-cakephp3/blob/master/src/Template/Element/pagination.ctp to update the pagination element.
  • In /tag/... pages, the words "upcoming" and "past" are no longer capitalized
  • On /tags, the category icons need cursor: pointer

from muncie-events3.

"remove" buttons appear below input fields instead of beside them

This is how it is in the 2.x version now too. Should I change the both of them?

from muncie-events3.

I'm only seeing that issue in the CakePHP 3 version:

The CakePHP 2 version looks correct:

from muncie-events3.

I recommend copying code from https://github.com/BallStateCBER/datacenter-plugin-cakephp3/blob/master/src/Template/Element/pagination.ctp to update the pagination element.

It wouldn't match the 2.x version if I did that, though. The current pagination element I've got uses Bootstrap pagination elements and is similar in design to the one I made for the 2.x version.

from muncie-events3.

New JavaScript error: Lines like muncieEvents.populatedDates['11-2009'] = [01,06,08,15,22,25,27,29]; generate errors for numbers that start with zero. This could be adapted to remove the leading zeros, or these values could be changed to strings.

Do you have an example of the error? Because there's no error like this on my end, nothing in the console etc. So I'm lost.

from muncie-events3.

Under "frequency", the weekly/daily options are missing and only the "custom" option is shown

This, I did on purpose to sort of downsize the form, so if someone wants an email every day then they can check every checkbox, or just the ones they'd like depending on the day, or if they'd like it weekly they can do that too.

from muncie-events3.

SyntaxError: 08 is not a legal ECMA-262 octal constant

A quick way to fix the problem would be in AppController::beforeRender(), changing the line

$populated["$month-$year"][] = $day;

to

$populated["$month-$year"][] = "'$day'";

But the better solution is probably to change this line in links_primary.ctp:

"muncieEvents.populatedDates['$monthYear'] = [".implode(',', $days)."];"

to

"muncieEvents.populatedDates = " . json_encode($populated) . ";"

from muncie-events3.

^Done. I wonder why I never got the error message.

from muncie-events3.