osm2pgrouting does not compile with libpqxx v 7.1.1, 7.2.0. Compiles okay with 6.4.7 about osm2pgrouting HOT 8 CLOSED

pgRouting has a well maintained Docker repository and as far as I know they all images contain osm2pgrouting as well: https://github.com/pgRouting/docker-pgrouting/ . Could you maybe compare what is different in the way you are creating a Docker image?

from osm2pgrouting.

It seems maybe they ran into the same problem? For example, looking at the dockerfile for the Postgres 13 version,

https://github.com/pgRouting/docker-pgrouting/blob/c0ae2c671ed730157970f397e60d803cb972b209/13-3.0-3.1.0/extra/Dockerfile

They pin osm2pgrouting version to 2.3.6 and also fix the version of libpqxx:

ENV OSM2PGROUTING_VERSION 2.3.6

RUN apt update \
 && apt install -y \
        libpqxx-6.2 \
...

from osm2pgrouting.

These errors from compiler are because Libpqxx v7.x require C++17.
Related to issue #289

from osm2pgrouting.

This is not a bug. It's an improvement so I'm going to change the tag.

from osm2pgrouting.

from osm2pgrouting.

In addition to compile flag -std=c++17, I also had to change

diff --git a/src/osm_elements/osm2pgrouting.cpp b/src/osm_elements/osm2pgrouting.cpp
index e11fb2f..37e6232 100644
--- a/src/osm_elements/osm2pgrouting.cpp
+++ b/src/osm_elements/osm2pgrouting.cpp
@@ -140,7 +140,7 @@ int main(int argc, char* argv[]) {
                 cout << "Can't open database" << endl;
                 return 1;
             }
-            C.disconnect ();
+            C.close ();
         }catch (const std::exception &e){
             cerr << e.what() << std::endl;
             return 1;

with my version of pqxx:

user:build$ grep VERSION /usr/include/pqxx/version.hxx 
#ifndef PQXX_H_VERSION
#  define PQXX_VERSION "7.3.1"
#  define PQXX_VERSION_MAJOR 7
#  define PQXX_VERSION_MINOR 3
#  define PQXX_VERSION_CHECK                                                  \
    check_pqxx_version_##PQXX_VERSION_MAJOR##_##PQXX_VERSION_MINOR
PQXX_LIBEXPORT int PQXX_VERSION_CHECK() noexcept;

from osm2pgrouting.

@jmarca
Sorry for the delay, the PR is ready if you can review #292 and leave a comment on the PR
The most critical part is the change on the minimum standard for C++

• C++ minimum standard depends on libpqxx
  • For version libpqxx 6: C++14
  • For version libpqxx 7: C++17 see here

I also modified FindPQXX that detects the version, can you verify that it works as it should.

from osm2pgrouting.

from osm2pgrouting.