Giter Club home page Giter Club logo

Comments (3)

download13 avatar download13 commented on June 27, 2024

toJSON is normally a function used for returning JSON serializable objects from an object that doesn't allow enumeration, or for when you want JSON to only serialize a portion of the object.
For example:

function A() {
  this.t = 4;
  this.prop = "test";
}
A.prototype.toJSON = function() {
  return {prop: this.prop}
}

var a = new A;

If a is ever stringifyed with JSON, you will end up with {"prop": "test"} instead of {"t": 4, "prop": "test"}.

tl;dr You might want to change this request to use a different function name.

from node-msgpack.

godsflaw avatar godsflaw commented on June 27, 2024

Can you help clarify? If I have an array:

var myArray = [ "one", "two" ];

and I pack that with msgpack.pack:

var binaryData = msgpack.pack(myArray);

You want a function that let's you say:

var jsonString = msgpack.unpack(binaryData, 'JSON');

I tend to agree with download13, we should not call it msgpack.toJSON(). I think making something like this an option to unpack is more desirable.

Is this what you mean?

from node-msgpack.

godsflaw avatar godsflaw commented on June 27, 2024

closing because of #50

from node-msgpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.