Comments (5)
Hi @Wytamma,
This is great! A PR would be very welcome.
A few notes:
- I have a concern about the groups and levels code. It seems if I specify levels, the order of levels could be scrambled. I think levels needs to be passed to as_factor and used to initialize the mapping.
- numpy.linalg.svd could be used instead of scipy, scipy is a fairly large dependency to have.
- To be consistent with elsewhere the class name should be "Langevitour" without a capital T.
from langevitour.
Hi @Wytamma,
Thanks. My PyPI username is pfh
from langevitour.
Pull request received and merged. New version uploaded to PyPI.
Thank you very much for this! It's been many years since I released a Python package, so I would have been quite baffled by where to start with the currently popular tooling. Fantastic to see Langevitour running in Jupyter notebooks.
from langevitour.
Excellent! I'll prepare and submit the PR this week :D
Also, do you have a PYPI account? I can add you as an own of the langevitour project so you can upload python releases to PYPI.
from langevitour.
Really glad to contribute to an awesome open source project 😊 thanks for accepting my PR!
from langevitour.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from langevitour.