Giter Club home page Giter Club logo

Comments (22)

lumenlunae avatar lumenlunae commented on July 30, 2024 7

@shoNagai Hello! How do you feel about your feature commits so far?

After trying and implementing react-window, react-virtualized, and react-virtuoso with beautiful-dnd, virtuoso was the one that caused me the least amount of problems but was missing horizontal. 🙏 How far did you get with it? I saw the branch had two commits in it. Thank you!

from react-virtuoso.

theromis avatar theromis commented on July 30, 2024 7

@shoNagai need horizontal scroll as well, have you had a chance to create a PR for your testing changes?

from react-virtuoso.

seschwartz8 avatar seschwartz8 commented on July 30, 2024 5

Any progress on horizontal scrolling?

from react-virtuoso.

seschwartz8 avatar seschwartz8 commented on July 30, 2024 5

any updates?

I ended up using react-window instead

from react-virtuoso.

petyosi avatar petyosi commented on July 30, 2024 4

@wibed with an attitude like the one in the comment above yours, I have little faith in the success of a such campaign.

from react-virtuoso.

petyosi avatar petyosi commented on July 30, 2024 3

Correct - I haven't implemented horizontal mode. I think that the code for the horizontal list will be exactly the same, but the component has to accept configuration to take scrollLeft / offsetWidth (vs scrollTop / offsetHeight) into account.

All in all, this is a relatively low complexity capability, but it needs tests, docs, etc. If you are interested in contributing, please let me know.

from react-virtuoso.

mihir-karbelkar-wiz avatar mihir-karbelkar-wiz commented on July 30, 2024 3

@wibed thanks. Maybe, I'll make try to make a pr for this.

Again, great work on the library @petyosi 🙌, found this to be one the best fit for the project, have looked at both react window and tanstack virtual.

Thanks, will try to help in this

from react-virtuoso.

NawarA avatar NawarA commented on July 30, 2024 2

This feature request is the main missing feature.

More people can use the library if horizontal is supported

Please add.

from react-virtuoso.

petyosi avatar petyosi commented on July 30, 2024 1

Thanks to @hipstersmoothie this feature is going to make it. Everyone, please check this implementation - looking for feedback.
https://codesandbox.io/p/sandbox/horizontal-virtuoso-j2xn2q?file=%2Fsrc%2FApp.tsx%3A8%2C5.

The horizontal positioning of the items is not "out of the box", so I chose to do so with inline-block.

from react-virtuoso.

shoNagai avatar shoNagai commented on July 30, 2024

@petyosi I want this feature too.
So I'm still testing it out, but I'll try to implement it.
feature/horizontal-list

from react-virtuoso.

chazzox avatar chazzox commented on July 30, 2024

any updates?

from react-virtuoso.

petyosi avatar petyosi commented on July 30, 2024

@NawarA - do you want to sponsor the development of the feature? If so, let me know.

from react-virtuoso.

NawarA avatar NawarA commented on July 30, 2024

@petyosi What do you mean? Are you asking me to pay you to release the feature?

from react-virtuoso.

wibed avatar wibed commented on July 30, 2024

@petyosi could you open a gofundme or similar so we can chip in?

from react-virtuoso.

mihir-karbelkar-wiz avatar mihir-karbelkar-wiz commented on July 30, 2024

Is this happening?

from react-virtuoso.

chazzox avatar chazzox commented on July 30, 2024

Petyosi afaik is not paid to maintain this package, making new features a long endevour. And since he his not making any money your essentially asking him to do work for free. As he has clearly stated, you can sponsor the repo, or make a pr (it is open source after all!). Otherwise the feature has no plans of coming any time soon. no shade on the dev, what he's asking for is entirely fair lmao

from react-virtuoso.

mihir-karbelkar-wiz avatar mihir-karbelkar-wiz commented on July 30, 2024

@chazzox I understand that, however I was deciding between react window and this and found out that horizontal lists are not supported, hence wanted to know if there are plans for this, if not I'll pick up some other library.

I am in no way forcing petyosi to build something, I just need information whether this is happening or not and on the basis of that I have to make a call for my project.

It's a great library and I was leaning into using it but then found out about horizontal lists.

from react-virtuoso.

wibed avatar wibed commented on July 30, 2024

@mihir-karbelkar-wiz its not.

from react-virtuoso.

ItamarSmirra avatar ItamarSmirra commented on July 30, 2024

Just here to support the need of this feature. Only if possible of course.

Mui mention this package in their documentation so I am guessing the feature requests (or maybe feature demands is more accurate) got grown much more.

Thank you.

from react-virtuoso.

petyosi avatar petyosi commented on July 30, 2024

@ItamarSmirra it's great that you are going to support this feature. Should I expect a sponsorship or PR from you? Let me know, thank you.

from react-virtuoso.

hipstersmoothie avatar hipstersmoothie commented on July 30, 2024

@petyosi I'm interested in sponsoring this work. If I were to sponsor you say for 2-3 months could we get this feature?

from react-virtuoso.

petyosi avatar petyosi commented on July 30, 2024

update: the sponsorship of this feature has been retracted. If someone is interested in having this published, contact me.

from react-virtuoso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.