[web] Crashes Flutter web apps on Safari about dart-petitparser HOT 9 CLOSED

@renggli @creativecreatorormaybenot It appears that the the bug is triggered when a parameter name matches the function name. In petitparser, this is the line in question:

Parser<String> char(Object char, [String? message])

Where char and char result in duplicated var names which is unsupported in JS. At least that's my understanding from catching up on the dart issue. My guess is that release mode obfuscates the var names which removes the name conflict.

If I rename Object char to something else like Object character on a local copy of the petitparser and reference by path in my pubspec.yaml, it appears that everything works in Safari. Can someone else confirm as this error? (I'm not certain my fix worked because the error doesn't consistently appear for me.)

If this rename resolves the issue, could we rename Object char to something else to avoid the dart2js name conflict? The dart-lang issue has been open for a while and debugging in Safari specific Flutter bugs has become a pain point for our team.

from dart-petitparser.

Not sure I can do anything here? This seems to be Flutter specific, all tests pass 02:43 +3972 ~8: All tests passed! when I run pub run test --platform=vm,chrome,firefox,safari,node or when running the tests with dart2native.

from dart-petitparser.

@renggli That is interesting - I can reproduce the issue 100% consistently using Flutter web - I wonder where the difference might be!

Do you think it is possible that there is a different Dart version used or that a different compiler is used?

I am able to reproduce it in debug mode, i.e. with DDC. In release mode, there are no logs, so I am not sure. Does --platform=safari use DDC or dart2js?

from dart-petitparser.

I am not sure what the difference between DDC or dart2js is? Is it somehow possible to run the tests of the packages with Flutter?

from dart-petitparser.

@renggli I doubt it. I think you could technically just run flutter test in the project repository, but I am not sure if this is going to change anything about the test results.

The difference between DDC and dart2js is that the Dart dev compiler is made for debug builds (creating "modular JavaScript") and dart2js is for deployment.

from dart-petitparser.

@renggli Looking at the error logs - do you have any idea which function could cause the duplicate parameter?

from dart-petitparser.

I had a look at https://github.com/petitparser/dart-petitparser/blob/master/petitparser/lib/src/parser/combinator/optional.dart and the generated JavaScript code, but couldn't spot anything suspicious.

from dart-petitparser.

I am closing the bug, this seems to be an issue in the Dart JS compiler: dart-lang/sdk#43520

from dart-petitparser.

I don't think this scales: A quick regular expression over this library yields at least two other instances of this situation, and it seems to be quite common in both the Dart SDK and Flutter itself (i.e. dev/devicelab/lib/framework/framework.dart). Please follow up on the bugs in Flutter/Dart.

from dart-petitparser.