Giter Club home page Giter Club logo

Comments (5)

renggli avatar renggli commented on August 10, 2024

Your grammar is left-recursive, meaning it references itself without consuming any input. Also your expression has no termination condition, thus it never stops.

Typically you can reorder the productions so that input is consumed before the recursion is closed:

Parser expressionSegment() => ref(sub_expressionSegment).optional();   // (2) teminate
Parser sub_expressionSegment() => ref(DOT) & ref(STAR) & ref(expressionSegment);   // (1) consume input first

Alternatively, it is usually easier to use one of the repeaters (star, plus, separatedBy, ...):

Parser expressionSegment() => (ref(DOT) & ref(STAR)).star()

from dart-petitparser.

pratikpparikh avatar pratikpparikh commented on August 10, 2024

@renggli I see you point won't change the grammar syntax?

Parser sub_expressionSegment() => ref(DOT) & ref(STAR) & ref(expressionSegment); // (1) consume input first

Are you recommending to interpret in correct order after parsing?

from dart-petitparser.

renggli avatar renggli commented on August 10, 2024

True, both of my proposals change the generated parse trees. The first proposal with recursion is kind of difficult to fix after the fact; the second one with the the repeaters producing flat lists is much simpler to interpret.

In any case, if you have more complicated expression parsers to build and interpret it is probably the simplest to use the ExpressionBuilder. It allows you to easily specify priorities and left/right associative operators.

from dart-petitparser.

Dokotela avatar Dokotela commented on August 10, 2024

@pratikpparikh Did you ever get this to work? If so, I'd be interested in discussing it more with you as I'm trying to do something similar, thanks!

from dart-petitparser.

pratikpparikh avatar pratikpparikh commented on August 10, 2024

@Dokotela I did it was not pretty then null safety came and thus I change course. It was becoming hard to maintain.

from dart-petitparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.