package:matcher (or maybe package:test) must be declared as a public dependency about dart-petitparser HOT 7 CLOSED

Fixed in c9dc90b.

from dart-petitparser.

Sigh...
That's not what I would expect.

We need to move test from dev_dependencies to dependencies.
Or remove lib/test.dart.

And it seems to me that package:browser is never imported by petitparser.

name: petitparser
version: 1.6.0
author: Lukas Renggli <[email protected]>
description: Dynamic parser combinator framework.
homepage: https://github.com/renggli/dart-petitparser
environment:
  sdk: ^1.8.0
dependencies:
  test: ^0.12.0

@kevmoo

from dart-petitparser.

This is the annoying thing about these packages. test.dart shouldn't be in this package. We don't want to leak a dependency on pkg/test into folks who use this.

Our only solution (now) – create a petitparser_test package.

Annoying? Yes.

from dart-petitparser.

package:browser is used by one of the examples.

test.dart provides test matchers for testing grammars. Wondering if this is a problem to depend on package:matchers, if the core library doesn't import it?

from dart-petitparser.

If you use something at runtime you need to add it to dependencies.

You might also want to look at the parallel discussion about the same problem in intl.

from dart-petitparser.

pkg/matcher is WAAAAY lighter thanpkg/test – likely okay to have as a normal dependency, me thinks.

from dart-petitparser.

I think this is no longer relevant and has been resolved a long time ago.

from dart-petitparser.