Some dead/uncovered code? about dart-petitparser HOT 6 CLOSED

All code used for debugging grammars.

removeDuplicates() is optimizing grammers for size, but it is currently not
used as it is too slow in JavaScript.

Everything you mentioned is optional, of course.

On Thursday, June 26, 2014, Rasmus Schultz [email protected] wrote:

I noticed the following functions and classes do not have test-coverage
and/or do not seem to be in use anywhere:

removeDuplicates()
profile()
progress()
debug()
ContinuationParser
_repeat()

Thoughts?

—
Reply to this email directly or view it on GitHub
#40.

Lukas Renggli (mobile)
http://www.lukas-renggli.ch

from dart-petitparser.

Right on. I only mentioned it because I've been porting PetitParserDart core again, this time to PHP - it's practically done and all core unit tests are ported and passing, all changes referenced and ported from the last check-in.

It's pretty neat to see all the tests passing - but I have been using the approach of porting the unit-tests first, then porting every component necessary to make the test pass, which left the mentioned features still unported.

I will push this to a public repo soon, just need to clean up and fix a few things :-)

from dart-petitparser.

Wow :-)

Thanks gor the reminder. I should indeed write some tests for this
functionality. At the time I wrote this there was not possible to redirect
'print(dynamic)', but now this is no longer the case.

Lukas

On Thursday, June 26, 2014, Rasmus Schultz [email protected] wrote:

Right on. I only mentioned it because I've been porting PetitParserDart
core again, this time to PHP - it's practically done and all core unit
tests are ported and passing, all changes referenced and ported from the
last check-in.

It's pretty neat to see all the tests passing - but I have been using the
approach of porting the unit-tests first, then porting every component
necessary to make the test pass, which left the mentioned features still
unported.

I will push this to a public repo soon, just need to clean up and fix a
few things :-)

—
Reply to this email directly or view it on GitHub
#40 (comment)
.

Lukas Renggli (mobile)
http://www.lukas-renggli.ch

from dart-petitparser.

Off-topic, but the port is public on GitHub now, listed on Composer/Packagist, and test-suite on TravisCI passing under PHP 5.3, 5.4 and 5.5. Good times :-)

https://github.com/mindplay-dk/petitparserphp

from dart-petitparser.

Cool, I've added a link to the readme.txt of the Dart version. I keep this bug open as a reminder to add tests for the untested code you found.

from dart-petitparser.

Extracted the debugging code to separate library and added tests in 60cff7b.

from dart-petitparser.