Giter Club home page Giter Club logo

Comments (3)

renggli avatar renggli commented on August 10, 2024

I don't like this style of describing grammars: It forces you to think about cycles in the grammar while writing the grammar. For every reference you have to decide if you want to use abc() or ref(abc). In either case the result is suboptimal: abc() will duplicate potentially large parts of the grammar and its construction, ref(abc) will recreate the complete grammar from that point on while parsing (which is horribly inefficient time and space wise). Also these hard coded assumptions about cycles makes reusability impossible and introduces possibly hard to detect bugs. Furthermore, I don't buy the argument about type-safety: The CompositeGrammar way is exactly as type-safe as your proposal, except that it only tells you about wrong references when instantiating the grammar. However, this is still before the actual grammar is executed. This analysis could potentially be part of dart_analyzer, when it becomes possible to add custom rules.

That said, I am perfectly fine making _parse a public method. I already started to make some classes public, for better reusability outside the library. Let me know if this would help you?

from dart-petitparser.

freewind avatar freewind commented on August 10, 2024

Yes, if I can create my RefParser in my own code, that will be great !

from dart-petitparser.

renggli avatar renggli commented on August 10, 2024

Renamed _parse to parseOn in c64e941.

from dart-petitparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.