bug about triadicmemory HOT 6 CLOSED

it is a bug in the function sdr_print(), I found

from triadicmemory.

Not a bug. The internal representation uses values from 0 to N-1. The command line interfaces uses values from 1 to N.
I added comments in sdr_print() and parse() to clarify.

from triadicmemory.

@PeterOvermann I do not understand because the Input are value from 1 to 9, where N=1000. it must return the value of x I inputted (1 2 3) and not (2 3 4) like you commented

from triadicmemory.

Your input was directly into the internal representation, not via the command line parser which subtracts 1 from each value.
You can use the following function to print the internal representation with values 0 to N-1:

void sdr_print_internal (SDR *s) // print sdr positions in the range 0 to N-1
{
for (int r = 0; r < s->p; r++)
{
printf("%d", s->a[r]);
if (r < s->p -1) printf(" ");
}
printf("\n"); fflush(stdout);
}

from triadicmemory.

from triadicmemory.

parse() is doing the right thing: it converts from the 1..N convention used in command line input to the C-internal convention 0..N-1. sdr_print() does the reverse conversion.

from triadicmemory.