Phobos trace and span are not properly propagated to Serilog contexts about phobos-issues HOT 1 CLOSED

Reproduced this issue. The problem is that Serilog is accessing ActiveSpan outside of the scope, and it is null in spite of the fact that it is set on global tracer.

The solution to this is using the following EnrichLogging implementation:

public static ILoggingAdapter EnrichLogging(IUntypedActorContext context)
{
	var tracer = context.GetInstrumentation().Tracer;
   
	var logger = context.GetLogger<SerilogLoggingAdapter>()
		.ForContext("dd.trace_id", tracer.ScopeManager.Active.Span.Context.TraceId)
		.ForContext("dd.span_id", tracer.ScopeManager.Active.Span.Context.SpanId);

	return logger;
}

Note that you need to get SerilogLoggingAdapter adapter, not just context.GetLogger(), to have ForContext helper working - as stated in the documentation: https://getakka.net/articles/utilities/serilog.html#extensions .

from phobos-issues.